[Implement sniff] Warn about short ternary usage in themes about wpthemereview

[jrfnl]

No need to extend the sniff, this can simply be changed from the ruleset <type>warning</type>.

[joyously]

?? usage would influence the minimum PHP version for the theme, wouldn't it?

[dingo-d]

Once core moves to PHP 7.0 (beginning of the next year) this shouldn't have to be an issue imo.

[joyously]

Once core moves to PHP 7.0

But this is for themes, not core. And themes can run on different versions of core, with different versions of PHP.

[jrfnl]

Both ?: (PHP 5.3+) usage, as well as ?? (PHP 7.0+) usage influence the minimum PHP version for a theme.

If I remember correctly, the "default" presumption is that themes support the current WP version + up to three versions back. That would currently mean WP 5.0 - 5.3, meaning the "normal" minimum PHP version for a theme would still need to be PHP 5.2, though this can be changed of course with the Requires PHP: header.

[joyously]

Yes, but considering that WP doesn't check the Requires PHP header for themes yet, the theme still needs to make sure that it doesn't fatal. And a warning to the reviewer would be good to have.

[jrfnl]

Well, the PHPCompatibilityWP ruleset which is included in TRTCS already does so as the minimum PHP version for that is set to 5.2.

[dingo-d]

The decision from the triage: include this sniff but change it so that it throws a warning instead of an error.

This shouldn't be too hard, just extend the sniff and override the process_token method

[dingo-d]

Even better 🙂