GithubHelp home page GithubHelp logo

Comments (2)

wsmd avatar wsmd commented on May 17, 2024

Hi @pocesar - there was a temporary regression with caching in 0.10.1 that was fixed in the latest version yesterday, so please make sure you are on 0.10.2.

It's worth noting that the caching issue you are seeing isn't related to the map itself. In fact, useRef doesn't create a new map on every re-render:

https://reactjs.org/docs/hooks-reference.html#useref

useRef returns a mutable ref object whose .current property is initialized to the passed argument (initialValue). The returned object will persist for the full lifetime of the component.

Here's in a example to demonstrate the performance of this library running on the latest version: https://yq1l6185ox.codesandbox.io/

Please make sure you are on the latest version and if you are still having any problems, post a comment here to let me know (preferably with a code example) and I'll be happy to re-open this issue.

from react-use-form-state.

pocesar avatar pocesar commented on May 17, 2024

yeah, I'm using the latest version, but that's not what I meant. the "new Map()" is eagerly executed, and not lazily like in:

const state = useState(() => {
  return { some: 'initialState' }
})

const memoized = useMemo(() => {
  return new Map()
}, [])

the way code is created in this library seems to not deal with ref stability (for functions, objects, etc). this is a constructive criticism, that should focus on optimizations. spread props is already bad by itself and is the main drive of this hook.
when using hooks from other people, we expect that the refs are stable, like here https://github.com/kitze/react-hanger/blob/master/src/useInput.ts#L19

from react-use-form-state.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.