GithubHelp home page GithubHelp logo

Comments (6)

sb10 avatar sb10 commented on August 21, 2024

I'm not clear on its behaviour when there's already something in the db for the file. From your description it sounds like it always just replaces the entry with a new not-notified entry? But then you'd get multiple emails about the same thing?

from hgi-vault.

sb10 avatar sb10 commented on August 21, 2024

Read and understand notification code, write it up

from hgi-vault.

sb10 avatar sb10 commented on August 21, 2024

On testing, 2 unexpected things happened:

  1. It sent an email about a file location that sandman wasn't just run on.
  2. The email contained the same fofn for all 3 warning time points.

from hgi-vault.

michael-grace avatar michael-grace commented on August 21, 2024

Corrections to the Above

  • The status is not "one status per file", it can be "many statuses to one file". Each warnings status will have its own tminus time.
  • This also means that a deletion status is added as another status to the file.
  • Deletion statuses are deleted by the schema.sql script at the start of each sandman run (so, a file will be marked as deleted status in the DB, then that status will be cleared on the next run)
  • The warning statuses (and therefore the files) aren't deleted, though files for archival are
  • It will send notification for all non-notified warning thresholds. Note: this will include even if the warning threshold configuration is actually changed during the warning period.

This means that the diagram should be:

                               W1       W1          W1
    W1       W1             W1 W2       W2          W2 DEL          DEL
    V        V              V  V        V            V  V            V
    |__________________________|________________________|________________>
 warning                     warning                  deletion
threshold                   threshold                threshold
    1                           2

As described above, sandman sends all notifications in the DB marked unnotified, even if the sandman run doesn't run on a directory referred to by one of those notifications.

from hgi-vault.

michael-grace avatar michael-grace commented on August 21, 2024

don't move file to limbo if no warning sent - send warning instead

from hgi-vault.

michael-grace avatar michael-grace commented on August 21, 2024

As an admin, if sandman can't run on a given day, I don't want it to skip warnings, so that users don't get surprised by unwarned deletions

from hgi-vault.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.