GithubHelp home page GithubHelp logo

Comments (6)

RobelTekle avatar RobelTekle commented on June 8, 2024 1

yes it works 😸

from welcome-ui.

theo-mesnil avatar theo-mesnil commented on June 8, 2024

Hi @RobelTekle @mleralec ,

We can add a hideOnClick={false} to the DropdownMenu.Item to fix this.

Did we want to do by default on our component ? Or i change the documentation to show another example ?

from welcome-ui.

RobelTekle avatar RobelTekle commented on June 8, 2024

@theo-mesnil maybe it’s better to add hideOnClick={false} directly to DropdownMenu component. We probably want the same behavior for each item, otherwise we can use the hide method in an Item onClick.

from welcome-ui.

theo-mesnil avatar theo-mesnil commented on June 8, 2024

@RobelTekle i think we need to add on our way this new props. A dropdownMenu need to be closed on click, i think we gonna migrate to the new components when it will be available. I test on our squad and it's work

from welcome-ui.

RobelTekle avatar RobelTekle commented on June 8, 2024

@theo-mesnil my bad, I did not understood that hideOnClick prop was already available on DropdownMenu.Item. That's great πŸ‘
Yes maybe we can juste add an example in the documentation

from welcome-ui.

theo-mesnil avatar theo-mesnil commented on June 8, 2024

@RobelTekle Yes i'll do that tomorrow, tell me if this works for you :)

from welcome-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.