GithubHelp home page GithubHelp logo

Comments (4)

Pagebakers avatar Pagebakers commented on June 14, 2024 1

Thanks for looking into this @anothermh , I've opened in internal issue to go over this.

from wundergraph.

Pagebakers avatar Pagebakers commented on June 14, 2024

Thanks for the elaborate report, this seems to be incorrect indeed. Have you also looked into a possible fix?

from wundergraph.

anothermh avatar anothermh commented on June 14, 2024

I've tried a number of different fixes where I use w.Header().Set("Content-Type", "application/json") prior to the error response (or any response) being sent but it never seems to stick. For example, I thought this block might be where to set the header but that wasn't it:

var validationError *inputvariables.ValidationError
if errors.As(err, &validationError) {
w.WriteHeader(http.StatusBadRequest)
enc := json.NewEncoder(w)
if err := enc.Encode(&validationError); err != nil {
log.Error("error encoding validation error", zap.Error(err))
}
return true
}

api.go and apihandler.go and errorhandler.go and internalapihandler.go combined are over 3k LOC so there's a lot of ground to cover in terms of understanding how it comes together. I don't frequently use Golang so it's possible that I'm missing an obvious fix.

Anybody is welcome to make a PR for this if they can find the right way to set the header in the response for validation errors. Unfortunately I've exhausted the time I can spend on it for now.

from wundergraph.

Pagebakers avatar Pagebakers commented on June 14, 2024

Fix: #1337

from wundergraph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.