Comments (5)
Yes, that could be the case.
However, there is not really much we can do in that case, except retrying. The other option would be to shut down / crash the consumer, after which the Zookeeper connection will eventually time out and the partition will be released implicitly.
I'd welcome PRs to make this more resilient.
from kafka.
What about notifying the caller (the piece of code that calls JoinConsumerGroup
) by sending an error into the errors
channel? This gives the opportunity to the caller to close the group and call JoinConsumerGroup
again.
Code would be something like this:
defer func() {
err := cg.instance.ReleasePartition(topic, partition)
if err != nil {
cg.Logf("%s/%d :: FAILED to release partition: %s\n", topic, partition, err)
cg.errors <- &sarama.ConsumerError{
Topic: topic,
Partition: partition,
Err: err,
}
}
}()
Does it seem reasonable to you? If so, I'll be glad to send you a PR.
Please, let me know that you think.
from kafka.
👍
from kafka.
Thanks in advance for taking a look at this PR
from kafka.
Should be fixed now your PR is merged.
from kafka.
Related Issues (20)
- zk: node does not exist HOT 1
- Is There Any Benchmark for the Consumer? HOT 1
- Lots of logs such as "abandoned subscription to xxx because consuming was taking too long" HOT 1
- Bug? Consuming stops or hangs at certain time.
- ConsumerGroup.Messages() HOT 3
- How to exit the program in kafka/examples/consumergroup/main.go gracefully? HOT 1
- Clarify Kafka version support HOT 3
- consumption message delay
- consumergroup not work in docker HOT 1
- Consumer group not consuming from partitions -- Kafka v11
- Some problems when I try to run my consumer in two node. HOT 3
- Trouble reliably reusing consumer group names across topics HOT 1
- Upgrading to kafka based offset storage HOT 1
- Kafka consumer not restarting after broker failure
- Leader change during re-balance may cause partition not being consumed HOT 4
- Can't receive messages when i test the demo which the project gives. HOT 4
- ConsumerGroup.FlushOffsets() HOT 3
- Version releases? HOT 2
- which tag or version support kafka 0.8 ?
- Is there any way to get to the ConsumerGroup. Instance. ID?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kafka.