Regression: Zoom bubble is seen in omnibox after switching view in pdf files about pdfium

[GoogleCodeExporter]

CHANGELOG URL:
  http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=277149%3A277157

suspecting: r277153 ?

Original comment by [email protected] on 24 Jun 2014 at 11:37

from pdfium.

[GoogleCodeExporter]

this isn't related to pdfium, but to chrome's UI, so please file in chromium 
repo.

and yes this is r277153 

Original comment by [email protected] on 24 Jun 2014 at 7:45

from pdfium.

[GoogleCodeExporter]

Yes, this seems to be an (unexpected) consequence of r277153. I believe this 
will be resolved when https://codereview.chromium.org/301733006/ lands.

Original comment by [email protected] on 24 Jun 2014 at 7:58

from pdfium.

[GoogleCodeExporter]

wjmaclean: can you confirm for sure?

Original comment by [email protected] on 24 Jun 2014 at 8:11

[GoogleCodeExporter]

I tested a few minutes ago on Linux ToT with 301733006 and the extra bubbles 
were gone. I haven't tested on Windows though.

Original comment by [email protected] on 24 Jun 2014 at 8:34

from pdfium.

[GoogleCodeExporter]

Hi wjmaclean, is this issue resolved?

Original comment by [email protected] on 18 Jul 2014 at 7:43

• Changed state: Started

[GoogleCodeExporter]

I checked on a ToT, and if I assume that when the bug description says "After 
switching to landscape or portrait view" it really means is"Switching between 
'fit page-width' and 'fit page-height' modes ...", then no, it doesn't seem to 
be fixed.

That being said, I think we were under the impression that the bubble was to be 
displayed anytime something other than the Chrome UI changed the zoom level, 
and in this case that's what's happening: the zoom change happens via 
PepperPluginInstanceImpl::ZoomChanged(). I seem to recall being told that the 
bubble should display when the + - zoom commands are invoked in the PDF viewer, 
which is the exact same pathway with nothing to distinguish between them.

I'd like to add some more people to this conversation (fsamuel@, dbeam@ to 
start) but I don't seem to have the necessary privilege ... can we perhaps move 
this to a crbug issue?

Original comment by [email protected] on 18 Jul 2014 at 4:45

from pdfium.

[GoogleCodeExporter]

Sure. Can you file a crbug issue and cc us? Thanks.

Original comment by [email protected] on 18 Jul 2014 at 4:48

[GoogleCodeExporter]

https://code.google.com/p/chromium/issues/detail?id=395182

I had to guess at your e-mails, since they're elided here ...

Original comment by [email protected] on 18 Jul 2014 at 5:33

from pdfium.

[GoogleCodeExporter]

Thanks. You got our emails right.

Original comment by [email protected] on 18 Jul 2014 at 6:10