wxPropertyGrid uses a very hard to read color for disabled properties in dark themes on Linux about wxwidgets

[vadz]

Strangely, I have a different problem: for me, with the default GNOME dark theme (i.e. dark variant of Adwaita), the disabled text colour is just the same white as for the normal cells. And this is not really surprising seeing that it is set to the same colour as the normal caption colour by default here:

wxWidgets/src/propgrid/propgrid.cpp

Line 1486 in ee309e0

m_colDisPropFore = m_colCapFore;

I can fix this by applying

diff --git a/src/propgrid/propgrid.cpp b/src/propgrid/propgrid.cpp
index 937d08e615..1ecfe88853 100644
--- a/src/propgrid/propgrid.cpp
+++ b/src/propgrid/propgrid.cpp
@@ -1499,7 +1499,7 @@ void wxPropertyGrid::RegainColours()
         m_colLine = m_colCapBack;
 
     if ( !(m_coloursCustomized & CustomColour_DisabledText) )
-        m_colDisPropFore = m_colCapFore;
+        m_colDisPropFore = wxSystemSettings::GetColour( wxSYS_COLOUR_GRAYTEXT );
 
     m_colEmptySpace = wxSystemSettings::GetColour( wxSYS_COLOUR_WINDOW );
 }

but I feel like I'm missing something here: how come the colour is grey even without this change in the light theme, as can be easily seen in the propgrid sample, which has a few disabled properties by default ("OS", "User Id", "User Name")?

[StefanBattmer]

@vadz: Many, many thanks! Fun fact: We just kind of met again: swig/swig#2889 ;-)