Item Tooltip Sizing and Positioning about artemis

[P0keDev]

Can you add a screenshot of this?

I feel there's a decent chance this is just vanilla behavior

[Kepler-17c]

Found that it can also happen in landscape format.

Landscape - in this case a broken item with JSON data as lore - also had this with a long list of roll predictions earlier:

Portrait - happens with a great portion of the items:

Both screenshots go all the way to the left border of my screen.

[P0keDev]

That top one is definitely just vanilla behavior - it's not getting affected by the tooltip feature at all since, like the one in legacy wynntils, it only checks the vertical borders of the screen. We could maybe add checks for horizontal borders as well but that's very rarely an issue in-game

That second one is definitely strange though. My guess is that the minecraft rendering system always handles dimensions as if they're 16:9 and does some extra processing for non-standard window sizes that we're not accounting for, but I'll have to look into it further. Could you attach a full screenshot so I know just what shape your window is?

[Kepler-17c]

Thought it might be a bit too big, but here you go:

[Kepler-17c]

As you can see from the squares, I'm on the most recent version (90) as of now.

[Incompleteusern]

A solution for the item guesses problem would be wrapping when the text gets too long.

[Kepler-17c]

Afaik that's currently the case on the 1.12.2 version

[Incompleteusern]

Yeah it might be good to consider that for 1.12.2 version. Another alternative is to further split from the four possible levels, one line for each level.

[Kepler-17c]

No, I mean it's already implemented - I'll have to switch versions to make sure, but as far as I remember, that broken item stopped at the side and wrapped to the next line

[kristofbolyai]

As you can see from the squares, I'm on the most recent version (90) as of now.

lol, thanks for pointing that out, it should not happen in production.😅 See #138 for tracking the issue.

[TomaSajt]

I did some testing, and it seems like this wrapping issue is only present with fabric and quilt (this is also the vanilla behavior). However with forge the wrapping works perfectly fine, the same as in 1.12.
I searched for the code making it possible in forge, but couldn't find the implementation (the method was empty).

[kristofbolyai]

I did some testing, and it seems like this wrapping issue is only present with fabric and quilt (this is also the vanilla behavior). However with forge the wrapping works perfectly fine, the same as in 1.12.

I searched for the code making it possible in forge, but couldn't find the implementation (the method was empty).

What was the method name? Was it not overwritten by something?

[TomaSajt]

What was the method name? Was it not overwritten by something?

I did some more searching and found how forge actually does it ForgeHooksClient::gatherTooltipComponents
But I also found some code which supposedly already does this wrapping in the vanilla code (it doesn't) screen::renderComponentHoverEffect

[kristofbolyai]

I will check out these and probably just implement forge behavior for the mod. We will need to disable the mod's code in Forge though, that will need a small change in the common side.

[TomaSajt]

correction: turns out screen::renderComponentHoverEffect is used when you hover over a hoverable text component. The wrapping seems to be working fine when hovering the text.