GithubHelp home page GithubHelp logo

Comments (9)

DonkeyBlaster avatar DonkeyBlaster commented on July 22, 2024 1

Town pairs like Nesaak and Nemract get same letter
this is the same behavior as legacy - i'm not sure how we could convey these differences easily

Since this bit is being rewritten anyway, the town names could get a 2 or 3 letter abbreviation
I felt like the 2 letters were really useful for the dungeon keys, and this could probably benefit the same way

oh kepler was already typing

from artemis.

IngeniousCoder avatar IngeniousCoder commented on July 22, 2024 1

Seems like the rendering is done based on the first letter of the item, which shouldn't be the case, and if it is, consider adding checks;

image

Rendering on Auction Page is wrong.

image

And the inner view further confirms my suspicion the rendering is done based on the first character of the item

from artemis.

P0keDev avatar P0keDev commented on July 22, 2024

Town pairs like Nesaak and Nemract get same letter

this is the same behavior as legacy - i'm not sure how we could convey these differences easily

boat passes don't have letters

not implemented yet

old dungeon keys don't have letters

is this really a valuable functionality?

emerald pouches don't have their tier

not implemented

from artemis.

Kepler-17c avatar Kepler-17c commented on July 22, 2024

this is the same behavior as legacy - i'm not sure how we could convey these differences easily

Probably needs specific exceptions - could use syllables (e.g. NA = Nesaak / NR = Nemract / RN = Ragni / RL = Relos / CK = Corkus / CF = Cinfras / ...)

is this really a valuable functionality?

Not really, but it would be cool to have them treated the same way as modern keys.

not implemented

I guessed so, but wanted to point it out anyway, so there's a note for planning and future updates.

from artemis.

Kepler-17c avatar Kepler-17c commented on July 22, 2024

The syllable thing doesn't allow things like using the first two words (e.g. Lost Sactuary -> LS), so it probably needs a hard-coded map of town name to abbreviation (should be fine though, as they barely change)

from artemis.

DonkeyBlaster avatar DonkeyBlaster commented on July 22, 2024

Is hard-coded necessary? I feel like the first three letters of each town name works quite well for nearly every town off the top of my head

RAGni
DETlas
CINfras
AHMsord
LUTho
ALMuj
SELchar
OLUx
GELibord

The only two I didn't really like were CORkus and TROms, but honestly even they are okay

from artemis.

Kepler-17c avatar Kepler-17c commented on July 22, 2024

I fear that might be too bulky 🤔
How about first 2?

from artemis.

DonkeyBlaster avatar DonkeyBlaster commented on July 22, 2024

Well first 2 would not solve the problem in the first place - NEmract and NEsaak

from artemis.

Kepler-17c avatar Kepler-17c commented on July 22, 2024

Ah, true :/

from artemis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.