GithubHelp home page GithubHelp logo

Comments (5)

magicus avatar magicus commented on July 22, 2024

There is a case in vanilla where this happens, just want to check this is not the case here. If this happens:

  1. you get a link in chat
  2. you talk to a NPC
  3. after talking, the old "screen" is restored

In this case, the "restore" in 3 does not restore links.

WIth the NPC dialogue overlay, this problem should be avoided.

from artemis.

magicus avatar magicus commented on July 22, 2024

I saw this behavior myself. It was immediately upon login to a new world/class, when Wynntils dumps a whole lot of messages at once. Then they are sent as a multiline screen, but (apparently) with proper Component contents available.

That means that I either need to make a function to split a massive Component constructor on line breaks (I'm not fond of writing that function!), or I need to find a way to encode Components into strings that does not lose any information (basically, finding a way to store hover and onClick data). This I've actually been thinking about for a while (it was needed for translation as well), and it seems like a more doable way, but it is still quite some effort.

I'll open a separate bug to track my thinking on the issue.

from artemis.

magicus avatar magicus commented on July 22, 2024

See #292

from artemis.

magicus avatar magicus commented on July 22, 2024

I'm starting to think this might be TranslationsFeature that is responsible. Are you sure you have it turned off?

from artemis.

kristofbolyai avatar kristofbolyai commented on July 22, 2024

Tracking this in #292.

from artemis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.