Comments (6)
Notices from another bug, specifically about translations:
Things we can do:
preserve leading spaces
preserve Wynntils item coding
encode a Component into a string using a custom format, keeping "hover" and "onclick" attributes.
At the moment, none of these seems really worth the effort. Keeping it here as a reminder.
from artemis.
Here are some ideas from discord on how to encode hover texts:
One of the problems I have not fully solved is that this might partially defeat our purpose of doing this in the first place. If you have a large hover text, then it will appear to be part of the message itself (I mean, in a way it is, but also not as we mean it), and any regex matches can mistakenly be triggered by the hover text instead.
Maybe we should just append the hover text as an "appendix" and reference it with a number or has from within the "real" string. We could then have the regexp cut off at a marker between the "real" text and the list of over appendices.
§aYou found a §3§{hover:1}Magical Unicorn!<EOTMARKER>1:§7Actually, it is a fake plastic copy.§r
That way we can chose whether we want to do regexp searches (and/or replacements) in both the "real" text and the hover, or only the real text. With that, we could even have like highlight of your user name in hovers.
from artemis.
More discord logs:
Or we could transform a Component into a record CodedString(String realMsg, List<Appendix> appendices)
If we do that, we get an additional change which might be both good and bad. I've been thinking about doing it intentionally, but have also dreaded the consequences: We need to replace all String with CodedString, wherever we have a coded string.
On the one hand, I think it is good to be explicit about this. But on the other hand, it is used in a loooot of places. And we'd probably have to convert back and forth between String and CodedString in several places.
from artemis.
Hello. Just curious when this will be fixed. Tested the mod and was not able to click on a link for a item bomb.
from artemis.
@Seadragon91 That has nothing to do with this enhancement. In fact, I have never heard of such a bug in Wynntils. Please go to the Discord if you need support.
from artemis.
Basically done by StyledText.
from artemis.
Related Issues (20)
- [Question] About the resource download issue of Chinese Players HOT 1
- [Proposal] - Allow overriding urls.json source link with a java properties
- Make translation feature work with NPC dialogues HOT 13
- Disabling Game Notifications overlay hides all notifications (unless it's parent feature is also disabled) HOT 2
- WorldStateModel needs to correctly handle Housing Islands
- The one-click join wynncraft button on the title screen crashes when using Blur Mod HOT 2
- Text renders black on the left side of the screen
- Crashes on launch when using v1.1.11+ HOT 2
- Unidentified Shiny Items are not annotated correctly HOT 1
- "donator" should be "donor"
- [Function request] Some features that may provide a better experience HOT 2
- "Press SNEAK to continue" has "<protected>" behind it HOT 6
- WorldStateModel breaks after /class in streamer mode HOT 2
- Game frequently crashes in trade market HOT 4
- Quest, cave, discoveries, and other things in content book take way too long to load HOT 10
- WAR_MESSAGE_PATTERN does not handle x minute and y second case
- [MapData] - Icon Fade is applied on the minimap HOT 4
- [MapData] - Minimum visibility to render is slightly off, allowing hovering unrendered features HOT 3
- [MapData] - Hovering does not work if multiple waypoints are stacked, and the one with the highest priority does not render HOT 1
- MalformedJsonException + error 'Signature is missing from Property textures' spamming in the console HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from artemis.