GithubHelp home page GithubHelp logo

Comments (6)

magicus avatar magicus commented on July 3, 2024

Notices from another bug, specifically about translations:

Things we can do:

preserve leading spaces
preserve Wynntils item coding
encode a Component into a string using a custom format, keeping "hover" and "onclick" attributes.

At the moment, none of these seems really worth the effort. Keeping it here as a reminder.

from artemis.

magicus avatar magicus commented on July 3, 2024

Here are some ideas from discord on how to encode hover texts:

One of the problems I have not fully solved is that this might partially defeat our purpose of doing this in the first place. If you have a large hover text, then it will appear to be part of the message itself (I mean, in a way it is, but also not as we mean it), and any regex matches can mistakenly be triggered by the hover text instead.

Maybe we should just append the hover text as an "appendix" and reference it with a number or has from within the "real" string. We could then have the regexp cut off at a marker between the "real" text and the list of over appendices.

§aYou found a §3§{hover:1}Magical Unicorn!<EOTMARKER>1:§7Actually, it is a fake plastic copy.§r

That way we can chose whether we want to do regexp searches (and/or replacements) in both the "real" text and the hover, or only the real text. With that, we could even have like highlight of your user name in hovers.

from artemis.

magicus avatar magicus commented on July 3, 2024

More discord logs:

Or we could transform a Component into a record CodedString(String realMsg, List<Appendix> appendices)

If we do that, we get an additional change which might be both good and bad. I've been thinking about doing it intentionally, but have also dreaded the consequences: We need to replace all String with CodedString, wherever we have a coded string.

On the one hand, I think it is good to be explicit about this. But on the other hand, it is used in a loooot of places. And we'd probably have to convert back and forth between String and CodedString in several places.

from artemis.

Seadragon91 avatar Seadragon91 commented on July 3, 2024

Hello. Just curious when this will be fixed. Tested the mod and was not able to click on a link for a item bomb.

from artemis.

magicus avatar magicus commented on July 3, 2024

@Seadragon91 That has nothing to do with this enhancement. In fact, I have never heard of such a bug in Wynntils. Please go to the Discord if you need support.

from artemis.

kristofbolyai avatar kristofbolyai commented on July 3, 2024

Basically done by StyledText.

from artemis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.