GithubHelp home page GithubHelp logo

Comments (5)

Incompleteusern avatar Incompleteusern commented on July 22, 2024

Joining hypixel with artemis/wynntils is inherently risky. But other than that, this implies a problem with the impl

from artemis.

P0keDev avatar P0keDev commented on July 22, 2024

Joining hypixel with artemis/wynntils is inherently risky.

What makes you say this? Legacy Wynntils disables all game-altering features if you're not on Wynncraft, so there's no issues on any other servers. Artemis should do the same

from artemis.

magicus avatar magicus commented on July 22, 2024

We used to start all even handlers with a "if !onWorld return;", more or less. (There are exceptions for stuff happening before logon.) This has not been done consistently. (Thought I doubt my recent refactoring did anything to change this particular bug.)

We might even consider if we should move that logic to when we send out the event... That would make everything more robust. Care needs to be taken for events needed to confirm that we are online, though...

from artemis.

kristofbolyai avatar kristofbolyai commented on July 22, 2024

Fixing #23 would be a nice start

from artemis.

KaspianDev avatar KaspianDev commented on July 22, 2024

Yep I agree it should only enable modifications to wynncraft (except of gamma?)

from artemis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.