Provide Timeout function for when checking a URL about aspnetcore.diagnostics.healthchecks

[CarlosLanderas]

The thing is the default timeout for the http client is 100 secs and it the service is down it can delay the heath check report. In Beatpulse we had the timeout feature integrated in the HealthChecks core but the AspNetCore healthchecks extensions will have to implement this by themselves until some kind of timeout configuration is provided by the AspNetCore library

[unaizorrilla]

Hi @grey007

Not now, sorry! I try to add this feature soon, of course contributions are open on this repo.

[pajzo]

Hi @unaizorrilla

Have you think about how to implement it? Because, maybe i will give it a try.

Maybe do some kind of loop for x minutes with x seconds/minutes between check before marks the check as degraded/unhealthy.

[CarlosLanderas]

I have already implemented it. Pull request pending thought. My approach has been configuring the httpclient timeout property.

[pajzo]

@CarlosLanderas Then i misunderstood the request - i thought it should check the endpoint multiple times before marking the check as unhealthy.

[agcos]

@CarlosLanderas any ideas when can we expect a PR?!

[wdamron]

On a related note, the UriHealthCheck currently ignores the passed-in CancellationToken when calling var response = await httpClient.SendAsync(requestMessage);

(see https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/blob/master/src/HealthChecks.Uris/UriHealthCheck.cs#L47)

[CarlosLanderas]

Merged in #85. Closing issue

[unaizorrilla]

Hi @grey007

A timeout feature is new on 2.2.2 package for Uri healthchecks from a @wdamron PR.

You can check functional tests in order to know how is used

https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/blob/master/test/FunctionalTests/HealthChecks.Uris/UriHealthCheckTests.cs