HealthCheck - AppSettings about aspnetcore.diagnostics.healthchecks

[vertonghenb]

@carlowahlstedt i implementeren something like this not so long ago I’ll pr it when I get back from vacation

[unaizorrilla]

Umm let me check with more people!

[vertonghenb]

@unaizorrilla sure , give me a heads-up when you have a design ready

[CarlosLanderas]

@vertonghenb, thanks for your contribution. I do think that appsettings checking should be a task that has to be done on startup. Is difficult for me to see it like a Health check. It might have sense it you configure your settings with hot reload tough

[unaizorrilla]

I can close this?

[vertonghenb]

@CarlosLanderas
The basic idea is that you:

• Always let the App Startup without any isses (wrong appsettings etc)
• But once the app is started, you can check for the AppSettings(if they're ok or not)

[carlowahlstedt]

I agree with @vertonghenb here. There might be situations where your app settings are invalid but it might only impact a small section of the site. Keeping the entire site from coming up, would mean that users couldn't even run in "degraded mode" until this one configuration was corrected.

This would also allow other libraries that require specific AppSettings to be configured to use this so that only their feature doesn't working but there can still be a notification that something isn't working.

Here's a specific example. I had configured App Insights but the copy/paste of the key was missing the last character. If I had this check, then the site would come up, and then throw a health-check that the value was invalid. I would have known right away that something was miss configured.