Verification of restart can crash the simulation about incompact3d

[airwarriorg91]

@mathrack Can you verify the changes you recommended ? It will be a great help.

if (adios2_restart_initialised) then
! First, rename old checkpoint in case of error
!call rename(resfile, resfile_old) !L255
end if
end if

! Validate restart file then remove old file and update restart.info
if (.true.) then !L318
!call delete_filedir(resfile_old) !L319
! Write info file for restart - Kay Schäfer

[mathrack]

Hello,

This is probably related to some subroutines associated with the "validation" of restart files. Try to avoid the subroutines renameand delete_filedir, they are moving or deleting stuff and this might cause your issue.

I would suggest to modify the file tools.f90 as follows :

• Comment the call to rename here https://github.com/xcompact3d/Incompact3d/blob/master/src/tools.f90#L255
• Replace the if condition returned by validate_restart with .true. https://github.com/xcompact3d/Incompact3d/blob/master/src/tools.f90#L318
• Comment the call to delete_filedir here https://github.com/xcompact3d/Incompact3d/blob/master/src/tools.f90#L319

Cheers,
Mathrack

[mathrack]

@pbartholomew08 if it is important to keep this validation step, we could make it optional

[airwarriorg91]

Okay I will check whether the issue is being resolved by the method. Thanks for the help !

[airwarriorg91]

@mathrack Thanks, I think the solution is working. My simulation is running for past 9 hrs without terminating. I will let you know the final results.

[mathrack]

Thank you for the update

[airwarriorg91]

@mathrack The 48hrs of simulation has completed without terminating. Thanks for the tip ! Great help. I think we can close the issue.

[mathrack]

Thank you for the feedback. I will re-open. I think the issue should remain open until we have made the verification of restart files optional.

Switching from bug to enhancement because this was not reported by other users.

[airwarriorg91]

Sure, thanks !