GithubHelp home page GithubHelp logo

Comments (15)

mlep avatar mlep commented on August 24, 2024 2

And prompt reply from John L.: he will upload the file ASAP.
I will take care of the file airspace.json afterward.

from xcsoar-data-repository.

mlep avatar mlep commented on August 24, 2024 1
  • OK for sending the file to the suitable person. Just me know who, please. 😉
  • OK for contacting the FFVP.

from xcsoar-data-repository.

mlep avatar mlep commented on August 24, 2024 1

Prompt reply from the FFVP airspace commission:

  • not possible to keep the same name for the OpenAir file because the version of the file must be visible from its name (FFVP rule).
  • the FFVP uses GoogleDrive to unify and simplify the access to important information

Hopeless...

from xcsoar-data-repository.

rawtaz avatar rawtaz commented on August 24, 2024

What is the URL for the most recent version? Once you have that URL, it's a simple matter of opening a PR, which you can do the following way:

  • Go to https://github.com/XCSoar/xcsoar-data-repository/blob/master/data/airspace.json .
  • Click the Edit button (the icon with a pencil).
  • Find and change the "http://soaring.gahsys.com/Airspace/FR/190523__AIRSPACE_FRANCE_2019-05.txt" to the new URL (keeping it in quotes), and the corresponding date three lines below the URL line (this date should be when the airspace data/file was updated, which you can usually find inside or alongside the file at the source).
  • At the bottom of the editing page, under the "Commit changes" heading, choose "Create a new branch for this commit and start a pull request", write something like "Update France airspace" in the one-line description field right under the "Commit changes" heading, then click "Commit changes".
  • On the next page, follow the instructions to open a pull request.
  • In the multi-line description textarea of the pull request form, make sure to include "Closes #151" which will then reference this issue.

After this you're a contributor and know how to contribute code/stuff on GitHub!

from xcsoar-data-repository.

mlep avatar mlep commented on August 24, 2024

Thanks for the detailed explanation.
So, the main issue is about the URL...
The current version is on a google drive: https://drive.google.com/file/d/1RbG6aIQThAYs5EcUOJF1bPG7QfQXbrd1/view

  • I am not sure if this URL will be the same for the next version.
  • You need to click on "download" to download the file...

from xcsoar-data-repository.

rawtaz avatar rawtaz commented on August 24, 2024

Thanks for checking. Not too happy about Google Drive being involved, but it is what it is unless someone knows a better place to get the file.

The direct download URL for the file is: https://drive.google.com/uc?export=download&id=1RbG6aIQThAYs5EcUOJF1bPG7QfQXbrd1

I got that URL by using https://sites.google.com/site/gdocs2direct/ but one can just edit the URL manually otherwise.

Can you try to file a PR with that URL (don't forget to update the date as well)?

from xcsoar-data-repository.

mlep avatar mlep commented on August 24, 2024

OK, I will do this.
Nice trick to get the direct download URL!

from xcsoar-data-repository.

lordfolken avatar lordfolken commented on August 24, 2024

Argh.. google drive for something as vital and important as this.
Can you motivate the FFVP to provide an official download link on a serious server? They get enough money from me every year.

My experience with dropbox and google drive links is that they expire and die.

An option is to host it with http://soaringweb.org. Send the updated file to john leibacher.

Then we can link to it with a stable service.

from xcsoar-data-repository.

rawtaz avatar rawtaz commented on August 24, 2024

Why not send it to the place that hosts the currently used file instead, http://soaring.gahsys.com/Airspace/HomePage.html ([email protected])?

from xcsoar-data-repository.

mlep avatar mlep commented on August 24, 2024
  • OpenAir file sent to John Leibacher.
  • Request for a proper URL sent to FFVP.

I will create a PR to update the file https://github.com/XCSoar/xcsoar-data-repository/blob/master/data/airspace.json when needed.

from xcsoar-data-repository.

rawtaz avatar rawtaz commented on August 24, 2024

Yeah, that's great, let's put this issue on hold until we get a better URL to use :) Nice work!

from xcsoar-data-repository.

rawtaz avatar rawtaz commented on August 24, 2024

Nice work @mlep, well done. Was this your first PR?

from xcsoar-data-repository.

mlep avatar mlep commented on August 24, 2024

@rawtaz. Thanks. No, it was not (I do not contribute code, but documentation, translation, etc.)

from xcsoar-data-repository.

rawtaz avatar rawtaz commented on August 24, 2024

Ah, well then, I didn't mean to suggest you were a beginner, I just assumed you hadn't made PRs before. Sorry about that, and thanks again!

from xcsoar-data-repository.

mlep avatar mlep commented on August 24, 2024

@rawtaz No offense! Cheers.

from xcsoar-data-repository.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.