Error when dejitter_timestamps=False on stream without samples about pyxdf

[jzerfowski]

Upload MWE with 0, 1 and 2 samples to expose the bug
mwe.zip

[cbrnr]

Thanks @jzerfowski! I'd rather not break out of the loop though, because that way you ignore any additional streams that also need to be processed. Therefore, I propose the following change (starting at line 383):

        for stream in temp.values():
            if len(stream.time_stamps) > 1:  # requires at least two samples
                duration = stream.time_stamps[-1] - stream.time_stamps[0]
                stream.effective_srate = len(stream.time_stamps) / duration
            else:
                stream.effective_srate = 0

I wonder why you could not open a PR - this should work. Can you provide more details? I would like you to implement this change because you found the issue, reported the issue, and proposed a solution, so you should be credited for all of that!

[jzerfowski]

@cbrnr

I wonder why you could not open a PR - this should work. Can you provide more details? I would like you to implement this change because you found the issue, reported the issue, and proposed a solution, so you should be credited for all of that!

Nevermind, I guess I just didn't look properly. Will open a PR for the next issue I find!

[agricolab]

hey, @cbrnr just had made that same design choice and opened a PR. Only difference was i initialized stream.effective_srate explitivly with a float, i.e 0.0.

3c712f2#diff-ef075678955858b0ccf9c1a819363246f7d68dc5a2aae4320a5f9ab91e164385R384-R388

Feel free to merge if that's ok with you.

[jzerfowski]

Hi @cbrnr, the proposed solution by @agricolab looks good to me, merging that PR would be fine for me. You're right that my break statement doesn't make sense. I guess this should have been a continue instead, but I guess the explicit if/else is more pythonic anyways.

[cbrnr]

Alright!