Build from git broken? about xemu

[Randrianasulu]

unfortunately it still errors out when using build.sh:

FAILED: libqemu-i386-softmmu.fa.p/hw_xbox_nv2a_pgraph.c.o                                          cc -m32 -Ilibqemu-i386-softmmu.fa.p -I. -I.. -Itarget/i386 -I../target/i386 -I../hw/xbox/nv2a/thirdparty/nv2a_vsh_cpu/src -Iqapi -Itrace -Iui -Iui/shader -Idata -I/usr/X11R7/include/pixman-1 -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/include/SDL2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -flto=auto -fdiagnostics-color=auto -Wall -Winvalid-pch -std=gnu11 -O3 -g -isystem /home/guest/botva/src/src/xemu/linux-headers -isystem linux-headers -iquote . -iquote /home/guest/botva/src/src/xemu -iquote /home/guest/botva/src/src/xemu/include -iquote /home/guest/botva/src/src/xemu/tcg/i386 -pthread -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wold-style-declaration -Wold-style-definition -Wtype-limits -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs -Wendif-labels -Wexpansion-to-defined -Wimplicit-fallthrough=2 -Wno-missing-include-dirs -Wno-shift-negative-value -Wno-psabi -fstack-protector-strong -DXBOX=1 -Wno-error=redundant-decls -fPIE -D_REENTRANT -Wno-undef -isystem../linux-headers -isystemlinux-headers -DNEED_CPU_H '-DCONFIG_TARGET="i386-softmmu-config-target.h"' '-DCONFIG_DEVICES="i386-softmmu-config-devices.h"' -MD -MQ libqemu-i386-softmmu.fa.p/hw_xbox_nv2a_pgraph.c.o -MF libqemu-i386-softmmu.fa.p/hw_xbox_nv2a_pgraph.c.o.d -o libqemu-i386-softmmu.fa.p/hw_xbox_nv2a_pgraph.c.o -c ../hw/xbox/nv2a/pgraph.c                       ../hw/xbox/nv2a/pgraph.c: In function 'pgraph_gl_sync':                                            ../hw/xbox/nv2a/pgraph.c:5341:45: warning: implicit declaration of function 'tcg_enabled' [-Wimplicit-function-declaration]                                                                            5341 |     pgraph_upload_surface_data(d, surface, !tcg_enabled());                                      |                                             ^~~~~~~~~~~                                    ../hw/xbox/nv2a/pgraph.c:5341:45: warning: nested extern declaration of 'tcg_enabled' [-Wnested-externs]                                                                                              ../hw/xbox/nv2a/pgraph.c: In function 'pgraph_mark_textures_possibly_dirty':                       ../hw/xbox/nv2a/pgraph.c:6405:18: warning: implicit declaration of function 'TARGET_PAGE_ALIGN'; did you mean 'HOST_PAGE_ALIGN'? [-Wimplicit-function-declaration]                                     6405 |     hwaddr end = TARGET_PAGE_ALIGN(addr + size) - 1;                                             |                  ^~~~~~~~~~~~~~~~~                                                               |                  HOST_PAGE_ALIGN                                                           ../hw/xbox/nv2a/pgraph.c:6405:18: warning: nested extern declaration of 'TARGET_PAGE_ALIGN' [-Wnested-externs]                                                                                        ../hw/xbox/nv2a/pgraph.c:6406:13: error: 'TARGET_PAGE_MASK' undeclared (first use in this function) 6406 |     addr &= TARGET_PAGE_MASK;                                                                    |             ^~~~~~~~~~~~~~~~                                                               ../hw/xbox/nv2a/pgraph.c:6406:13: note: each undeclared identifier is reported only once for each function it appears in                                                                              ../hw/xbox/nv2a/pgraph.c: In function 'pgraph_check_texture_dirty':                                ../hw/xbox/nv2a/pgraph.c:6422:13: error: 'TARGET_PAGE_MASK' undeclared (first use in this function) 6422 |     addr &= TARGET_PAGE_MASK;                                                                    |             ^~~~~~~~~~~~~~~~                                                               ../hw/xbox/nv2a/pgraph.c: In function 'pgraph_update_memory_buffer':                               ../hw/xbox/nv2a/pgraph.c:6976:13: error: 'TARGET_PAGE_MASK' undeclared (first use in this function) 6976 |     addr &= TARGET_PAGE_MASK;                                                                    |             ^~~~~~~~~~~~~~~~                                                               ../hw/xbox/nv2a/pgraph.c: In function 'pgraph_bind_vertex_attributes':                             ../hw/xbox/nv2a/pgraph.c:7134:36: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]                                                                                      7134 |                                    (void *)attrib_data_addr);                                    |                                    ^                                                       ../hw/xbox/nv2a/pgraph.c:7138:35: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]                                                                                      7138 |                                   (void *)attrib_data_addr);                                     |                                   ^                                                        [1468/1527] Compiling C object libqemu-i386-softmmu.fa.p/hw_xbox_nv2a_pmc.c.o                      [1469/1527] Compiling C object libqemu-i386-softmmu.fa.p/hw_xbox_nv2a_pramdac.c.o                  [1470/1527] Compiling C object libqemu-i386-softmmu.fa.p/hw_xbox_nv2a_prmdio.c.o                   ninja: build stopped: subcommand failed.                                                           make[1]: *** [Makefile:165: run-ninja] Error 1                                                     make[1]: Leaving directory '/home/guest/botva/src/src/xemu/build'                                  make: *** [GNUmakefile:11: qemu-system-i386] Error 2                                                                                                                                                  real    3m22.237s                                                                                  user    7m46.368s                                                                                  sys     1m15.795s

[Randrianasulu]

oh, it was my attempt at fixing it that broke something (changed include somewhere)

git reset --hard fixed that

still, new lto error:

../hw/xbox/mcpx/apu.c: In function 'is_voice_locked.constprop.isra':                               ../hw/xbox/mcpx/apu.c:470:13: error: call to 'qemu_build_not_reached_always' declared with attribute error: code path is reachable                                                                      470 |     return (qatomic_read(&d->vp.voice_locked[v / 64]) & mask) != 0;                              |             ^                                                                              make[2]: *** [/tmp/ccNrA9UB.mk:380: /tmp/cc13GToc.ltrans126.ltrans.o] Error 1                      make[2]: *** Waiting for unfinished jobs....                                                       lto-wrapper: fatal error: make returned 2 exit status                                              compilation terminated.                                                                            /usr/bin/ld: error: lto-wrapper failed                                                             collect2: error: ld returned 1 exit status                                                         ninja: build stopped: subcommand failed.                                                           make[1]: *** [Makefile:165: run-ninja] Error 1

next try - without lto ...

[Randrianasulu]

After removing lto switch from build.sh

FAILED: libqemu-i386-softmmu.fa.p/hw_xbox_mcpx_apu.c.o                                             cc -m32 -Ilibqemu-i386-softmmu.fa.p -I. -I.. -Itarget/i386 -I../target/i386 -I../hw/xbox/nv2a/thirdparty/nv2a_vsh_cpu/src -Iqapi -Itrace -Iui -Iui/shader -Idata -I/usr/X11R7/include/pixman-1 -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/include/SDL2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -fdiagnostics-color=auto -Wall -Winvalid-pch -std=gnu11 -O3 -g -isystem /home/guest/botva/src/src/xemu/linux-headers -isystem linux-headers -iquote . -iquote /home/guest/botva/src/src/xemu -iquote /home/guest/botva/src/src/xemu/include -iquote /home/guest/botva/src/src/xemu/tcg/i386 -pthread -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wold-style-declaration -Wold-style-definition -Wtype-limits -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs -Wendif-labels -Wexpansion-to-defined -Wimplicit-fallthrough=2 -Wno-missing-include-dirs -Wno-shift-negative-value -Wno-psabi -fstack-protector-strong -DXBOX=1 -Wno-error=redundant-decls -fPIE -D_REENTRANT -Wno-undef -isystem../linux-headers -isystemlinux-headers -DNEED_CPU_H '-DCONFIG_TARGET="i386-softmmu-config-target.h"' '-DCONFIG_DEVICES="i386-softmmu-config-devices.h"' -MD -MQ libqemu-i386-softmmu.fa.p/hw_xbox_mcpx_apu.c.o -MF libqemu-i386-softmmu.fa.p/hw_xbox_mcpx_apu.c.o.d -o libqemu-i386-softmmu.fa.p/hw_xbox_mcpx_apu.c.o -c ../hw/xbox/mcpx/apu.c                                              In file included from ../hw/xbox/mcpx/apu.c:22:                                                    ../hw/xbox/mcpx/apu.c: In function 'is_voice_locked.constprop.isra':                               /home/guest/botva/src/src/xemu/include/qemu/osdep.h:184:35: error: call to 'qemu_build_not_reached_always' declared with attribute error: code path is reachable                                        184 | #define qemu_build_not_reached()  qemu_build_not_reached_always()                                |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                          /home/guest/botva/src/src/xemu/include/qemu/osdep.h:195:50: note: in expansion of macro 'qemu_build_not_reached'                                                                                        195 | #define qemu_build_assert(test)  while (!(test)) qemu_build_not_reached()                        |                                                  ^~~~~~~~~~~~~~~~~~~~~~                    /home/guest/botva/src/src/xemu/include/qemu/atomic.h:136:5: note: in expansion of macro 'qemu_build_assert'                                                                                             136 |     qemu_build_assert(sizeof(*ptr) <= ATOMIC_REG_SIZE); \                                        |     ^~~~~~~~~~~~~~~~~                                                                      ../hw/xbox/mcpx/apu.c:470:13: note: in expansion of macro 'qatomic_read'                             470 |     return (qatomic_read(&d->vp.voice_locked[v / 64]) & mask) != 0;                              |             ^~~~~~~~~~~~

may be clang as cc will fix it? Also building on slackware -current x86-64

[Randrianasulu]

./build.sh --debug works, without debug param it fails ...

[Randrianasulu]

aah, there was build.sh and it sets

--extra-cflags="-DXBOX=1