GithubHelp home page GithubHelp logo

Comments (9)

lzoia-bc avatar lzoia-bc commented on May 24, 2024

I tried the latest version 2.6.0 and the parentTransformId doesn't work still.
I suppose the error now is inside SceneModel.createTransform when the transform is created. I see that the parent transform is sent to the SceneModelTransform constructor using the parameter parentTransform, while the SceneModelTransform constructor code is reading cfg.parent.
I think this bug is still present since is not possible to use the parentTransformId feature yet

from xeokit-sdk.

xeolabs avatar xeolabs commented on May 24, 2024

I haven't made a test yet, but seemed an obvious thing to patch - try: https://github.com/xeokit/xeokit-sdk/releases/tag/v2.6.1

from xeokit-sdk.

lzoia-bc avatar lzoia-bc commented on May 24, 2024

I just tried and I'm getting the following error

TypeError: childTransform._setWorldMatrixDirty is not a function
    at SceneModelTransform._addChildTransform (xeokit-sdk.es.js:80390:1)
    at new SceneModelTransform (xeokit-sdk.es.js:80383:1)
    at SceneModel.createTransform (xeokit-sdk.es.js:83363:1)

from xeokit-sdk.

xeolabs avatar xeolabs commented on May 24, 2024

I can't test right now, but _setWorldMatrixDirty() should probably should be _transformDirty(), if you'd like to try modifying that and testing against your code.

from xeokit-sdk.

lzoia-bc avatar lzoia-bc commented on May 24, 2024

I just tried with 2.6.2 and I'm getting the following error

TypeError: childTransform._setAABBDirty is not a function
    at SceneModelTransform._addChildTransform (xeokit-sdk.es.js:80391:1)
    at new SceneModelTransform (xeokit-sdk.es.js:80383:1)
    at SceneModel.createTransform (xeokit-sdk.es.js:83363:1)

from xeokit-sdk.

lzoia-bc avatar lzoia-bc commented on May 24, 2024

I modified locally childTransform._setAABBDirty(); with childTransform._setSubtreeAABBsDirty(this); and it seems to work fine against my code

from xeokit-sdk.

lzoia-bc avatar lzoia-bc commented on May 24, 2024

I created this PR with the above change #1469

from xeokit-sdk.

lzoia-bc avatar lzoia-bc commented on May 24, 2024

Re-opened PR #1471

from xeokit-sdk.

lzoia-bc avatar lzoia-bc commented on May 24, 2024

I tried with 2.6.6 and it's working fine. Maybe it could be worth to update the docs and tell that the parentTransformId is available starting from 2.6.6

from xeokit-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.