TINYINT converted to boolean about migrations-generator

[Xethron]

It could be a problem with Doctrine, converting tinyint fields to boolean. Will have to take a look.

[warksit]

$table->boolean() in way generators goes back to tinyint anyway?

[tomzx]

@cnanney,

What would be the issue with this conversion? $table->boolean() is effectively tinyint(1).

The generated field type (when $table->boolean() is called during the migration process) will depend on laravel's schema grammar.

[cnanney]

I see I accidentally typed tinyint(1) in instead of tinyint(4) in my initial report... corrected.

I see two issues with this... first, it is not a faithful recreation of the DB if all tinyint are assumed to be boolean. Converting tinyint(4) -> boolean() which is tinyint(1) is incorrect.

Second, at least for MySQL, the Laravel boolean type is only a shortcut for tinyint(1) as you said. So when you write boolean in your migrations you are explicitly giving extra context as to what will be stored in that field.

But, when reverse-engineering a table there is no way to infer what that tinyint field was being used for, no matter the display width. So in this case, on MySQL, I think it should just stay tinyint, so tinyint(1) -> tinyInteger() and tinyint(4) -> tinyInteger(), etc. Don't even bring boolean into it, because all that really says in the migration is "I intend to only store true/false values here", which you have no way of knowing.

Again, this is minor stuff, and the second issue if more a matter of semantics than anything.