GithubHelp home page GithubHelp logo

Comments (8)

thymikee avatar thymikee commented on May 20, 2024

Apart from above, I'd like to adjust our current ITCSS structure.

  • Move normalize to generic/ dir
  • Make clearfix a mixin instead of placeholder beacuse of known problems
  • Use BEM naming. Add .footer__list and .footer__list-item to _footer.scss component plus couple of extra components. Developers are more likely to follow a given pattern if there is such, so we need to provide good foundation :)
  • Add more documentation on why we're using ITCSS

from generator-chisel.

luboskmetko avatar luboskmetko commented on May 20, 2024

Sounds good!

One thing - how would you move normalize to generic if normalize is installed via npm?

from generator-chisel.

thymikee avatar thymikee commented on May 20, 2024

Maybe there's an issue I'm not aware of, but doing

/* generic/_reset.scss */
@import 'normalize-scss/sass/normalize/import-now';

inside e.g. generic/_reset.scss works for me, as it's just an import from node_modules.

from generator-chisel.

luboskmetko avatar luboskmetko commented on May 20, 2024

Ok, thanks

from generator-chisel.

danekszy avatar danekszy commented on May 20, 2024

Hey guys.
@thymikee All suggestions look good to me except No. 3...
I wouldn't drop the c- prefix for classes, since doing so would make it less obvious whether (the previous) developer followed the guidelines or not. This way I wouldn't be able to tell if something is a component class, or some deviation from our recommended style (or even some 3rd party vendor stuff).

from generator-chisel.

luboskmetko avatar luboskmetko commented on May 20, 2024

I had doubts about no. 3 as well, I would rather stick to the convention. On the other hand, if writing c- over and over would bother developers or make them sick of ITCSS, we could allow this small departure from the standard or let developers decide ("Components' class names can be written with .c- prefix or without it...")

from generator-chisel.

thymikee avatar thymikee commented on May 20, 2024

Ok, so let's leave it to promote good practices and avoid confusion for newcomers.

from generator-chisel.

arturkot avatar arturkot commented on May 20, 2024

Just wanted to write I'm glad we decided to keep c- prefixes. :)

from generator-chisel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.