Error while editing a file about xi-mac

[cmyr]

Hmm that's interesting. I haven't seen this crash before. Were any plugins activated, besides the syntax coloring? Have you seen it more than once? @trishume might have a better idea of what's going on here, he rewrote this recently.

[trishume]

This is probably my fault, but I don't know why yet. I'll try to remember to debug this on Monday.

[dsego]

@cmyr Only syntax coloring is active. It predictably crashes after a minute or two, every time. So far it hasn't crashed on new buffers, only when editing an existing file.

[trishume]

Okay I figured out the cause of this bug, the Engine::gc method doesn't handle collecting revisions that aren't the oldest ones properly, which produces an invalid history which is caught by the dynamic checking on the next GC.

I'm not sure whether to fix the GC or just delete it, since I'm not sure if we need it anymore. I'll talk to @raphlinus about it later.

[cmyr]

@trishume sounds good, thanks for looking into this.

[trishume]

For now if you need a workaround you can set MAX_UNDOS to 1_000_000 in editor.rs to effectively disable the GC.

[cmyr]

@dsego Would you like to confirm that this has resolved your crash?

[dsego]

@cmyr Looking good 👍

[cmyr]

@dsego great, thanks! 😄