Build does not work with zsh-only features in zshrc about xi-mac

[belak]

@mitchhentges Unfortunately, if you're building directly from xcode, you won't have the environment variables in that instance. The PR cmyr mentioned looks like the best option at the moment.

[cmyr]

@belak okay noted, I wasn't sure what the best approach to this was. (I'm still not). All we're really interested in is making sure cargo is in our path, I think. I'm not sure what the elegant solution is.. 😒

[belak]

Potentially you could check if cargo is on the PATH and if it isn't, there would be a config file somewhere which would specify the location.

[jansol]

How about checking if CARGO_HOME is set and if it isn't ask the user to set it before building, potentially with a .env file. KISS.

[belak]

Yeah, I think that might be a good option.

…

On Sun, Aug 27, 2017 at 11:35 jansol ***@***.***> wrote: How about checking if CARGO_HOME is set and if it isn't ask the user to set it before building? Potentially with a .env file. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#58 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGiWXZJkNwGW_2iWXSUS40tMsFUn2Zxks5scbcDgaJpZM4O5f9s> .

[cmyr]

@belak @jansol let me know if this looks like an improvement: #61

[mitchhentges]

Hey, maybe you don't need to source either bash_profile or zshrc. Whatever shell the user is using, if its rc file adds cargo to the path (or sets CARGO_HOME), then build-rust-xcode.sh has all the information it needs. If the necessary variables aren't set, then sourcing the rc file again (bash_profile or zshrc) won't have an effect, right?

I can make a PR to remove the source lines, if that makes sense.