Comments (6)
This is known, but it's good to have a bug for it. The underlying problem is that opening a new tab is not sending a scroll
RPC to the core, letting the core know the window size.
This might be because viewDidAppear
is not getting called, or it's possible that there's an ordering problem so it's being called before a valid scroll
notification can be sent.
from xi-mac.
A looked into this a little, and found that repro was inconsistent (it was particularly hard to repro when I was looking closely). Also, a quick scan of the code shows that it's trying to do the right thing - if the RPC isn't set up, the scroll request goes into a pending queue. So there's something deeper going on here.
from xi-mac.
Just realized what the bug is, here while working on something related:
When we open in an existing tab, the logic that does the initial line fetch doesn't happen because it is called from the view's viewDidAppear
, which happens when we first open the tab but before we open the file.
Not sure what the best solution is, but should be trivial.
from xi-mac.
@lennylxx Would you like to check and see if you can still reproduce this on master? I believe it's fixed, but I had trouble reproducing consistently.
from xi-mac.
@cmyr Build on top of 4603667 and xi-editor/xi-editor@53f4267, it can't be reproduced.
I think it's fixed. Thank you for the work!
from xi-mac.
@lennylxx great, thanks for the follow-up!
from xi-mac.
Related Issues (20)
- autosave triggers HOT 11
- Xcode colorscheme HOT 3
- xi --wait does not return after application exit HOT 1
- update to swift 5 HOT 9
- Doesn't compile for Swift 5 HOT 13
- Change default find highlight color HOT 2
- package ID specification `xi-syntect-plugin` matched no packages
- build-rust-xcode.sh fails with Permission denied (os error 13) HOT 6
- Status Bar hiding last line HOT 3
- Scroll bars disappearing when switching from different application HOT 3
- Drag events cause file to be opened HOT 1
- Wrong top margin with statusbar -- first visible line is not rendered
- Crash when deleting (backspace) selection HOT 2
- Line numbers become bogus when scrolling HOT 1
- xcodebuild error (Xcode 11.3.1) HOT 14
- (Save) Dialog Overshoots Window in Splitwindow mode (macOS Catalina)
- Where is built .app? HOT 1
- No text is displayed at all
- no such module 'ArgumentParser' HOT 9
- xcodebuild fails on Mac Version OS 12 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xi-mac.