GithubHelp home page GithubHelp logo

Comments (9)

raphlinus avatar raphlinus commented on September 25, 2024 1

Nah, I think we can consider this closed by #58, because multiple EditViews is certainly not something that was working before. I've just been committing stuff, but since this is becoming more of a collaborative project we can totally have tracking issues for features we're working on.

from xi-win.

LiHRaM avatar LiHRaM commented on September 25, 2024

I'd like to start work on reworking it into a xi-win-ui app - I can see you've already implemented the ext_listener - should I base my branch off of that one?

from xi-win.

raphlinus avatar raphlinus commented on September 25, 2024

Yes, or we can just merge the PR; it's mostly up there in case you had any questions or concerns about it.

Glad to have you working on it!

from xi-win.

LiHRaM avatar LiHRaM commented on September 25, 2024

Okay, sounds good.
I have a question in regards to this issue, though. Am I correct to assume that we'll want to remove any dependencies xi-win has directly on winapi/xi-win-shell, and that xi-win can expect all of that behavior to be implemented via xi-win-ui?

EDIT: I've taken a better look at the examples provided, and I can see that it's a healthy mix of both, I'll just get started on rewriting edit_view into a Widget and rendering it via main.rs.

from xi-win.

raphlinus avatar raphlinus commented on September 25, 2024

Right, there's still a bunch of functionality provided by xi-win-shell (window creation, menus, etc). But EditView itself needs to be pretty much entirely in terms of xi-win-ui, as the event handling, painting, etc., need to be dispatched so they can be shared with other widgets in the window.

An additional point: the file open/save dialog is right now directly on winapi, but this also should be abstracted through the toolkit. That could be a separate project (in the PR that was lost, I used git_hwnd to hack it).

from xi-win.

raphlinus avatar raphlinus commented on September 25, 2024

@LiHRaM I might want to work on this again, is that ok? Or if there's something I can do to help, let me know.

from xi-win.

LiHRaM avatar LiHRaM commented on September 25, 2024

@raphlinus Totally fine if you want to work on this. :)

from xi-win.

LiHRaM avatar LiHRaM commented on September 25, 2024

Not sure when we should consider this issue closed, but as you mentioned multiple EditViews, maybe that would be an appropriate point?

It would be possible to start that once #45 and #59 are merged.

from xi-win.

LiHRaM avatar LiHRaM commented on September 25, 2024

Okay, I'll close it then.

from xi-win.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.