Comments (9)
I have a set of patches to propose.
0001-Use-a-standard-linked-list-idiom.txt
0002-Straighten-out-the-logic-in-fdt_init_node.txt
0003-Fix-segfault-in-xilinx_intc_fdt_auto_parent.txt
0004-Put-sysbus-MMIO-in-system-memory-map.txt
from qemu.
Thanks for contributing!
A few comments:
Unfortunately the patches do not pass checkpatch, you can try on your own by doing:
git show | ./scripts/checkpatch.pl -
It would also be great if you could prefix the summary of the commit message with something.
E.g fdt-generic: Some description
You can see examples in the history for a specific file or submodule with git log -- file.c
Also, if the patch is non-obvious, it would be great if you could provide some context in the commit-message, e.g for patches 2 & 4.
I've fixed up and applied patch 1 & 3.
Could you please fix up and resubmit patch 2 & 4, perhaps as a pull request on github?
Thanks again for contributing!
Cheers,
Edgar
from qemu.
from qemu.
from qemu.
0001-Straighten-out-the-logic-in-fdt_init_node.txt
0002-Put-sysbus-MMIO-in-system-memory-map.txt
from qemu.
Hi,
I've applied patch #1.
Patch number 2 breaks our system though. We rely quite heavily on attaching devices to the actual parent bus. I'm not sure how we'd work around this for device-tree's that don't match this. Perhaps you could find a way to specifically catch the orphaned case and apply your logic only in that case.
Did you publish the device-tree causing problems somewhere?
Is that device-tree auto-generated or are we in a position to hand-edit it?
Thanks,
Edgar
from qemu.
The device tree that causes the problem was auto-generated by the Xilinx HSI utility (although I hand edited system-top.dts to add the memory@0 node). I'm attaching the files.
I'll take another look and see if I can find a better way. To be honest, this method felt pretty heavy-handed when I did it.
from qemu.
OK, here's another swing at the problem. I'll admit my understanding of QOM and QDev (and the relationship between the two) is limited, but it looks like when MMIO regions (e.g. "amba_pl") are "orphaned", they get added as "child" type properties to the root node of the object tree. This code finds those properties and adds them to the system bus memory map. Passes checkpatch.pl.
0001-Put-orphaned-MMIO-into-system-memory-map.txt
from qemu.
from qemu.
Related Issues (20)
- ERROR: glib-2.22 gthread-2.0 is required to compile QEMU HOT 1
- Xilinx QEMU for Windows 10
- SRIOV support to remote-port
- How to run QNX OS on qemu HOT 6
- MPSoC CAN QEMU acceptance filter register layout not compatible with hardware HOT 2
- arm: cp15 support
- cadence_i2c.c DATA register issue
- Cannot recreate QEMU Petalinux commands HOT 1
- Enable virtfs in xilinx-qemu?
- Remote for `dtc` submodule points to deprecated git.qemu-project.org HOT 2
- Assessment of the difficulty in porting CPU architecture for qemu
- Block device read operation misses one byte(8 bit) per chip per SPI transaction HOT 3
- Error:undefined reference to `fcntl64'
- No null check on info leads to segfault
- QEMU Object Model for PL
- QEMU - How to enable two GEMs on xilinx-zcu102 machine HOT 4
- qemu support of VCR register on Cortex-A9
- Remote Port: need to disable/enable byte_enable
- Secure Boot with Xilinx QEMU
- qemu-system-aarch64: Connection refused
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from qemu.