VS2015 DLL build fails to export library info functions about opus

[wiiaboo]

There are no separate VS projects for celt and silk anymore. Are you sure you're using master branch?

[mqp]

Ah, I see. I was building from the v1.1.3 tag.

[nacho]

I am having the same problem with 1.1.3. I tried to build the alpha version but it does not seem to properly build for me. i.e the vs project points out to files that do not exists anymore. Did you have more luck here @mquander ?

[wiiaboo]

The alpha is only missing a fix for test_opus_encode, but other than that there should be absolutely no references to non-existing files. Git master is also missing a fix for DebugDLL opus_demo.

[nacho]

@wiiaboo using dumpbin on the generated DLL do you see the opus_strerror method exported?

[wiiaboo]

Yes: https://i.fsbn.eu/win32-exports.txt https://i.fsbn.eu/x64-exports.txt
From opus.dll output from ReleaseDLL Win32 and x64 respectively.

Grab the artifacts from any of these builds and check yourself. These are built from git master.

[nacho]

I just tried master and I confirm it builds properly and opus_strerror is exported

[AraHaan]

Master does build properly but if you download the zip file from the official website then it will not.

Just now need to get official website to actually download the master zip file from github which is easy to do. This would then be easier for them to get the updates and at same time no need to update the link to it after (unless this repo moves or is renamed or something)

[wiiaboo]

@AraHaan Github archives aren't supported. You should be using git itself or release tarballs/zips.

[AraHaan]

you do know the download as zip button on the base of the repo if you was to copy that link address it is supported then the end users would not know you did not upload any zip files.
like the one for master on this repo is: https://github.com/xiph/opus/archive/master.zip besides no matter how the website is made it is supported to link the zip file from another location. That is what I meant by having the official page allow the user to download the master zip file from this github repo without actually needing to go to this repo. This then eliminates needing to upload a zip file or whatever archive format it does support directly to the official site.

[wiiaboo]

It's supported by Github, obviously, but not by the developers of Opus. The zip archive of a git repository is not the same thing as the git repository or a tarball of a release.

[nacho]

I just tested 1.1.4 and the problem persists.... :(

[wiiaboo]

1.1.4 doesn't include any changes to the VS tree.
Either test with latest 1.2 or git master. Only git master has the VS changes.

[jmvalin]

Not going to fix for 1.1.x, but based on what I see here, it'll work for 1.2, which should be out in the not too far future, so it should be good. Please reopen if this is incorrect.