Compilation Error - celt/arm/{fft_arm.h, mdct_arm.h} include config.h unconditionally about opus

[rawr51919]

Actually making a config.h for this version might be able to solve the compile issue.

[Brahmasmi]

Unfortunately, I do not know whether creating a config.h is the solution, and if it is, what should be the contents of the file.

I assumed that the files (celt/arm/{fft_arm.h, mdct_arm.h}) are missing a HAVE_CONFIG_H check. I based this assumption on similar checks across the code base. As an example, in https://github.com/xiph/opus/blob/master/src/opus_encoder.c#L28-L30.

#ifdef HAVE_CONFIG_H
#include "config.h"
#endif

[rawr51919]

Then it should (most likely) be put in, & see if that fixes these errors.

On 6/1/16, Brahmasmi [email protected] wrote:

Unfortunately, I do not know whether creating a config.h is the solution,
and if it is, what should be the contents of the file.

I assumed that the files (celt/arm/{fft_arm.h, mdct_arm.h}) are missing a
HAVE_CONFIG_H check. I based this assumption on similar checks across the
code base. As an example, in
https://github.com/xiph/opus/blob/master/src/opus_encoder.c#L28-L30.

#ifdef HAVE_CONFIG_H
#include "config.h"
#endif

---

You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#6 (comment)

[jmvalin]

Two things here:

1. The #include "config.h" should always be within an #ifdef HAVE_CONFIG_H
2. We should never include config.h from a header file
   So we'll have to fix both, but it might take some time since I need to have a setup to make sure I don't break anything in the process.

[rawr51919]

Hopefully that happens soon.

On 11/11/16, Jean-Marc Valin [email protected] wrote:

Two things here:

1. The #include "config.h" should always be within an #ifdef HAVE_CONFIG_H

2. We should never include config.h from a header file
   So we'll have to fix both, but it might take some time since I need to have
   a setup to make sure I don't break anything in the process.

You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#6 (comment)

[mark4o]

Fixed by mjbshaw in 4911460.

[rawr51919]

If this is already fixed, shouldn't it be tested first before this gets closed?

[jmvalin]

Feel free to reopen if problems remain