Comments (7)
I think these are spurious. On line 89 we have
silk_assert( d==10||d==16 );
then on line 113, the loop bound is set to
dd = silk_RSHIFT( d, 1 );
so dd
is either 5 or 8. Meanwhile the array itself is size SILK_MAX_ORDER_LPC / 2 + 1
which is 9 (by SigProc_FIX.h:38) so the k+1
array access is safe.
Any suggestions how we can silence the warning? Which compiler version shows the issue?
from opus.
Latest Cygwin, rillian. I'm currently using the x64 version.
from opus.
what does gcc --version
say?
from opus.
It reports gcc 5.3.0.
from opus.
zturtleman fixed this error in Spearmint. Here's the changelog for the error fix: zturtleman/spearmint@a3da9be
from opus.
Thanks for the link. I'd rather not just turn the warning off, since it can find real bugs elsewhere.
Oddly, I can't reproduce with gcc 5.3 or 6.1 on linux, nor with cross-mingw32-gcc 6.1 on linux with the opus autotools build, and not with gcc 6.0 on linux with the spearmint build (although I do see array-bounds warnings for several other spearmint submodules). I also don't see any differences between the silk code in the opus master branch verses the spearmint fork which would change the array bound calculation.
from opus.
He reverted the changes explained here because it broke compilation on Mac OS X 10.6.8.
from opus.
Related Issues (20)
- Missing opus 1.5 github release HOT 4
- Windows: Meson build fails with nnet_avx2.c compiled without AVX2 HOT 23
- Compiling libopus 1.5.1 with Linux fails on ARM Cortex-A53 and Cortex-A55 HOT 21
- opus 1.5.1-1 seems to be incompatible with musescore 4.2.1 HOT 1
- Question about DRED HOT 4
- Undefined reference to opus_select_arch HOT 2
- opus_repacketizer_cat sometimes fails
- Limiting the stack allocation request HOT 2
- Please update opus-tools to support new features
- Deep PLC performance on Android HOT 16
- Compiling with CMake for Windows/MSVC only supports DLL runtime libraries HOT 9
- Added the OPUS_SET_INBAND_FEC(2) option HOT 1
- Please provide an option to not depend on downloading model data HOT 10
- v1.5.2 compile warnings
- Error: Range coder state mismatch between encoder and decoder in frame 1: 0x f3b1240 vs 0x40123b0f HOT 1
- Opus.lib: 1.3.1 version crashing in some windows machines in opus_encoder_create HOT 2
- Opus 1.5.x and main compilation failing with GCC 8.5.0 HOT 1
- Opus not building on Ubuntu 24.04
- No way to turn off the PLC/FEC?
- Floating Point libraries failing to build when targeting Fixed Point support only. MSVC 2017 v141 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opus.