GithubHelp home page GithubHelp logo

Comments (11)

manekinekko avatar manekinekko commented on June 9, 2024 1

I also like having the name in the top toolbar. However, I think we also should add an icon based on the file type. For the context, we currently use SketchApp and *.sketch files, but we are planning on adding more design tools. So having the icon of the app (before the file name) would help users quickly identify which design file they are using.

from xlayers.

anediaz avatar anediaz commented on June 9, 2024 1

You can take a look to my branch : https://github.com/anediaz/xlayers/tree/display-original-filename-in-editor
I've created a file named 'supported-files.ts' which is resposible for giving information about a file based on its name.
I have to fix a cypress test and I'll be ready to create a Merge Request.

It looks like this :
xlayer1
xlayer2

from xlayers.

anediaz avatar anediaz commented on June 9, 2024 1

Yes I agree, it would be better showing explicitly the version number, without charging the screen too much.
I think giving this information is important, but it is not something the user wants to see in a first view.
So I think the mouse over action will be appropriate to show this kind of information.

In addition, currently version number returned by 'supported-files.ts' is used nowhere, so I think your remark makes even more sense.

from xlayers.

anediaz avatar anediaz commented on June 9, 2024

I've started to work on this issue.
I hesitate about where to place the file's original name : On the top horizontal bar (editor component) or the left side panel (preview component), or another place?

I've made these two tests, to have an idea of the look :
left
horizontal

from xlayers.

Jefiozie avatar Jefiozie commented on June 9, 2024

Personally I find the one with the filename in the top pretty nice. I would remove the .sketch part, this way people only see the name. @manekinekko what do you think?

from xlayers.

anediaz avatar anediaz commented on June 9, 2024

Personally I find the one with the filename in the top pretty nice. I would remove the .sketch part, this way people only see the name. @manekinekko what do you think?

I agree with you, I think it'll be better without the extension. I hope juste it is clear enough, I mean, users will understand it is original file's name

from xlayers.

anediaz avatar anediaz commented on June 9, 2024

This is an excellent idea, I strongly believe the use of visual elements will improve the user experience!

I'll think about a structure that contains information of all the file types xlayers is compatible with, information we may need for this feature but also future.

  • Application/file type name
  • Extension
  • Logo (or the way to get it)
  • Supported or compatible versions with xlayes
    ...

In addition, it will be possible to update it later if we need other informations that we have not included yet.

What do you think about it?

from xlayers.

manekinekko avatar manekinekko commented on June 9, 2024

Sounds good. Can you make a proposal?

from xlayers.

manekinekko avatar manekinekko commented on June 9, 2024

This looks great!

I am wondering if we should explicitly show the version number? maybe we can show it as a title on mouse over the icon? Or something like that?

Because some other software might have some long version numbers like 56.32.5582

WDYT?

from xlayers.

anediaz avatar anediaz commented on June 9, 2024

Hello,
I think we can close this issue. My PR has been merged since some weeks, I've checked : https://xlayers.dev/
and I see that file's icon is present, but not the version number on mouse over. I think it is related to build cycle.

from xlayers.

Jefiozie avatar Jefiozie commented on June 9, 2024

Thank you pointing this out, I will close the issue.

from xlayers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.