GithubHelp home page GithubHelp logo

Comments (6)

ivan-aksamentov avatar ivan-aksamentov commented on May 18, 2024 1

Okay, you just witnessed a rubber duck debugging session. 🦆

I investigated the

throws errors for all form fields in the form

part and found that I should not have returned from the .then() part of the snippet above, because formik treats the returned things as errors (I returned valid values). So, this was a bug (also, "thanks" to eslint promise/always-return rule that convinced me I should return something). It seems that previously the returned thing did not reach formik, hiding the bug, but now it does reach somehow.

So the question is: what changed in use-debounce from v3? Did it not return the value before and now it does?

Anyways, this solves it for me, so feel free to close. But I hope this information might help someone else to debug their transition to v4.

from use-debounce.

ivan-aksamentov avatar ivan-aksamentov commented on May 18, 2024 1

@tryggvigy, small planet :)

hope covid19_scenarios is going well

Yep, it's thriving. 6+ months into pandemic, we are now swimming in data. Initial predictions were totally correct too. Not sure if I should be glad or sad about it all. Just released changes for "The Second Wave". Not looking good.

Feel free to close this, folks. Might also add a quick note on the new return behavior to the list of breaking changes, and/or to the readme, in case someone else steps on it.

from use-debounce.

xnimorz avatar xnimorz commented on May 18, 2024 1

I'll add it to the changelog and then I'll close the issue :)

from use-debounce.

tryggvigy avatar tryggvigy commented on May 18, 2024

Hi @ivan-aksamentov! Nice to see you again 😄 hope covid19_scenarios is going well.

So the question is: what changed in use-debounce from v3? Did it not return the value before and now it does?

Yes, that's right. The new version mimics lodash's implementation of debounce which returns the value.
I'm sorry you had to spend time debugging!

from use-debounce.

xnimorz avatar xnimorz commented on May 18, 2024

Hi @ivan-aksamentov

Yes, now v4 use-debounce returns the value.

from use-debounce.

xnimorz avatar xnimorz commented on May 18, 2024

Added f9f4cb3 :)

from use-debounce.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.