GithubHelp home page GithubHelp logo

Comments (7)

CoreyD97 avatar CoreyD97 commented on August 21, 2024 1

Those are just some examples, but yes that's the expected outcome. That particular website ended up with a bunch of duplicate entries because of the presence of these cache buster parameters. As for the FILTER_KEYWORDS, that behavior is fine :)

from urless.

xnl-h4ck3r avatar xnl-h4ck3r commented on August 21, 2024 1

I kept it as cachebuster,cacheBuster as the default :)
You can now get that change in v2.0, the latest.
Thanks for using it and taking the time to raise suggestions!

from urless.

xnl-h4ck3r avatar xnl-h4ck3r commented on August 21, 2024

Hi @CoreyD97. Have you got some examples you can share? If there are a number of URLs with similar parameters, it should take care of those, so maybe I'm misunderstanding what you mean.

from urless.

CoreyD97 avatar CoreyD97 commented on August 21, 2024

Sure! I've hidden the target here but can share the domain if you need. The input file was taken directly from the waymore output.

image

from urless.

xnl-h4ck3r avatar xnl-h4ck3r commented on August 21, 2024

Thanks. I'll look at adding some option to provide a list of parameters to exclude

from urless.

xnl-h4ck3r avatar xnl-h4ck3r commented on August 21, 2024

Just to clarify... Were you wanting cache buster parameters to be removed completely from the output?
So if you had this input:

https://test.com//jquery.paginate.min.js?v=2022090506&_=1558677431432
https://test.com/jquery.paginate.min.js?v=2022090507
https://test.com//jquery.paginate.min.js?v=2022090507&_=1558677431434

You just want to see this as output?

https://test.com//jquery.paginate.min.js

Also, just so you are aware, by default jquery is in the FILTER_KEYWORDS so a lot of those URLs wouldn't appear at all if you removed the parameters _ and v. The FILTER_KEYWORDS are only applied to URLs without parameters.

from urless.

xnl-h4ck3r avatar xnl-h4ck3r commented on August 21, 2024

Great! I have done the change and almost ready to release. I have added a REMOVE_PARAMS key to config.yml and also added an argument -rp/--remove-params that can override the config file. Both will be a comma separated list of parameter names.
I was thinking of defaulting the config key value with cachebuster.
I think it's best if the parameter names are case sensitive, so maybe I can set the default as cachebuster,cacheBuster so people can see an example if they want to add more param names. What do you think? Any parameter names you'd add?

from urless.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.