GithubHelp home page GithubHelp logo

Comments (4)

thekid avatar thekid commented on July 19, 2024

Doesn't occur with GitHub, which seems to have a more relaxed (and intuitive) understanding of callback URL matching.

from web-auth.

thekid avatar thekid commented on July 19, 2024

Microsoft Office 365 OAuth has the same restriction on paths - documented here: https://docs.microsoft.com/en-us/azure/active-directory/develop/reply-url - but is even stricter and doesn't allow request parameters.

image

from web-auth.

thekid avatar thekid commented on July 19, 2024

The "relaxed" way doesn't seem the intended way, though. The documentation states:

Often times a developer will think that they need to be able to use a different redirect URL on each authorization request, and will try to change the query string parameters per request. This is not the intended use of the redirect URL, and should not be allowed by the authorization server. The server should reject any authorization requests with redirect URLs that are not an exact match of a registered URL.

...and concludes:

If a client wishes to include request-specific data in the redirect URL, it can instead use the β€œstate” parameter to store data that will be included after the user is redirected. It can either encode the data in the state parameter itself, or use the state parameter as a session ID to store the state on the server.

We should store request parameters in the session and pass them behind rather than appending them to the redirect_url field; this will work in any case.

from web-auth.

thekid avatar thekid commented on July 19, 2024

Fixed in https://github.com/xp-forge/web-auth/releases/tag/v2.1.0

from web-auth.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.