GithubHelp home page GithubHelp logo

Comments (7)

stepelu avatar stepelu commented on June 21, 2024

I thought this had been done already in 1f37cec (see "ad1d22e Fix #509 by checking Nan/Inf when writing a double") ?

from lua-rapidjson.

xpol avatar xpol commented on June 21, 2024

Yes it still result 2.696539702293474e308:

LuaJIT 2.0.4 -- Copyright (C) 2005-2015 Mike Pall. http://luajit.org/
JIT: ON CMOV SSE2 SSE3 SSE4.1 fold cse dce fwd dse narrow loop abc sink fuse 
> j = require('rapidjson')
> print(j.encode(0/0))
2.696539702293474e308

from lua-rapidjson.

miloyip avatar miloyip commented on June 21, 2024

Strange... BTW, I think it is needed to check the return bool of Double, and raise error in Lua.

from lua-rapidjson.

xpol avatar xpol commented on June 21, 2024

It does not return false when encoding 0/0 in lua.

from lua-rapidjson.

miloyip avatar miloyip commented on June 21, 2024

Yes. I have asked GitHub support that recently some PR was merged but the commit was lost in the history.

from lua-rapidjson.

miloyip avatar miloyip commented on June 21, 2024

I have got one e-mail but the admin don't think there is problem.
I manually cherry-pick the merge again and it should be in the master.
https://github.com/miloyip/rapidjson/blob/master/include/rapidjson/writer.h#L245

from lua-rapidjson.

xpol avatar xpol commented on June 21, 2024

Updated and tested in commit 7918f5b.

from lua-rapidjson.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.