Comments (11)
I see you've updated the scripts. Remember, you need to use LuaRocks HEAD until 2.2.3 is released (due to cmake support)
from lua-rapidjson.
Does the cmake_geneartor="Visual Studio 12 2013" support x64 build?
https://github.com/keplerproject/luarocks/blob/master/src/luarocks/build/cmake.lua#L44 is a elseif not end and if.
from lua-rapidjson.
Yes, it does. What LuaRocks does is to add -DCMAKE_GENERATOR_PLATFORM=x64 to the command line.
from lua-rapidjson.
I'm running some tests now. It seems that I might have missed something in the script. Please hold on :)
from lua-rapidjson.
👌
from lua-rapidjson.
I think luarocks don't have -DCMAKE_GENERATOR_PLATFORM=x64
set since https://github.com/keplerproject/luarocks/blob/master/src/luarocks/build/cmake.lua#L44 is a elseif.
from lua-rapidjson.
Thank you. That was it. I couldn't understand why it started to fail once I corrected the configuration.
https://ci.appveyor.com/project/ignacio/lua-rapidjson/build/job/eqpn24grlbx2bbyf
Give me a minute, I'll fix in LR itself.
from lua-rapidjson.
My fixes here works.
But I'd like to wait you fixes to luarocks and remove the platform tail for cmake_generator.
from lua-rapidjson.
Well, thanks for the PR. I'll add that, but I think the fix must not be done in LuaRocks. When you choose the generator, you can specify if you want 64 bits, so we should not second guess the user in this case. So, that elseif is ok. We'll need the platform tail for cmake_generator.
I'm polishing the fix you submitted so it adds the Win64 when necessary.
BTW, that trick with the script variables is neat. Didn't know that.
from lua-rapidjson.
OK. Thank you very much @ignacio !
And I think the x64 flag should applied only once like my setup here:
https://github.com/xpol/lua-rapidjson/blob/master/.scripts/install.bat#L166-L176
Which I does not repeat my self 😄 .
Thank you for your pull request.
You are a great warm ❤️ man to work with!
from lua-rapidjson.
😄 Thanks!
from lua-rapidjson.
Related Issues (20)
- How to get full error list HOT 1
- why need cmake > =3.1? HOT 2
- cmake 2.8 build failed HOT 1
- question: how to compile `lua-rapidjson` with specified Lua/Luajit version. HOT 10
- question: how can I get the new value with default value. HOT 1
- validator occur coredump in centos 7 HOT 4
- Adding data to decoded empty table produce no change when encode again HOT 8
- build failed in RAM server HOT 1
- rapidjson.Document seems to not be freed correctly HOT 4
- decode 会给空的json对象添加元表 ‘json.object’, 导致table.insert(t), encode 产生错误的结果 HOT 1
- Macosx接入XLua的时候报了编译错误 HOT 3
- How to decode "null" as nil Default ! (not as rapidjson.null)
- lua-rapidjson dump 可以往别的路径写入文件么 HOT 1
- `nullref` might be changed unexpectedly while require rapidjson multi times in different lua states. HOT 3
- Compile XLua with lua-rapidjson integrated HOT 4
- Illegal instruction (core dumped) in aws ec2 HOT 2
- 不支持 ios、osx、osx_silicon 系统
- windows mingw64, can not link to lua51.dll
- Dangling reference in SchemaValidator after garbage collection, SEGFAULT HOT 1
- object is treated as array after casting a table from object to array
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lua-rapidjson.