GithubHelp home page GithubHelp logo

Update build scripts about lua-rapidjson HOT 11 CLOSED

xpol avatar xpol commented on June 21, 2024
Update build scripts

from lua-rapidjson.

Comments (11)

ignacio avatar ignacio commented on June 21, 2024

I see you've updated the scripts. Remember, you need to use LuaRocks HEAD until 2.2.3 is released (due to cmake support)

from lua-rapidjson.

xpol avatar xpol commented on June 21, 2024

Does the cmake_geneartor="Visual Studio 12 2013" support x64 build?
https://github.com/keplerproject/luarocks/blob/master/src/luarocks/build/cmake.lua#L44 is a elseif not end and if.

from lua-rapidjson.

ignacio avatar ignacio commented on June 21, 2024

Yes, it does. What LuaRocks does is to add -DCMAKE_GENERATOR_PLATFORM=x64 to the command line.

from lua-rapidjson.

ignacio avatar ignacio commented on June 21, 2024

I'm running some tests now. It seems that I might have missed something in the script. Please hold on :)

from lua-rapidjson.

xpol avatar xpol commented on June 21, 2024

👌

from lua-rapidjson.

xpol avatar xpol commented on June 21, 2024

I think luarocks don't have -DCMAKE_GENERATOR_PLATFORM=x64 set since https://github.com/keplerproject/luarocks/blob/master/src/luarocks/build/cmake.lua#L44 is a elseif.

from lua-rapidjson.

ignacio avatar ignacio commented on June 21, 2024

Thank you. That was it. I couldn't understand why it started to fail once I corrected the configuration.

https://ci.appveyor.com/project/ignacio/lua-rapidjson/build/job/eqpn24grlbx2bbyf

Give me a minute, I'll fix in LR itself.

from lua-rapidjson.

xpol avatar xpol commented on June 21, 2024

My fixes here works.
But I'd like to wait you fixes to luarocks and remove the platform tail for cmake_generator.

from lua-rapidjson.

ignacio avatar ignacio commented on June 21, 2024

Well, thanks for the PR. I'll add that, but I think the fix must not be done in LuaRocks. When you choose the generator, you can specify if you want 64 bits, so we should not second guess the user in this case. So, that elseif is ok. We'll need the platform tail for cmake_generator.

I'm polishing the fix you submitted so it adds the Win64 when necessary.
BTW, that trick with the script variables is neat. Didn't know that.

from lua-rapidjson.

xpol avatar xpol commented on June 21, 2024

OK. Thank you very much @ignacio !

And I think the x64 flag should applied only once like my setup here:

https://github.com/xpol/lua-rapidjson/blob/master/.scripts/install.bat#L166-L176

Which I does not repeat my self 😄 .

Thank you for your pull request.
You are a great warm ❤️ man to work with!

from lua-rapidjson.

ignacio avatar ignacio commented on June 21, 2024

😄 Thanks!

from lua-rapidjson.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.