npm run webpack failed after npm install about xpring-common-js

[dangell7]

I believe I have solved it with a PR? Let me know if I did something wrong?

[dangell7]

#117

[keefertaylor]

I'm offline for the holidays for the next few days, but wanted to chime in and hopefully get you building.

If you'd like to build this code, you should see CONTRIBUTING.md in this repository.

If you're trying to build the Swift code, you should see CONTRIBUTING.md in the XpringKit respository.

(Aside, if you'd expect to see the build instructions for a repo somewhere other than CONTRIBUTING.md, and I can see if we can make this more obvious).

To get this repository building, you'll just need to pull down your submodules once. We leave the submodules pinned to a certain commit (and I believe passing --remote pulls from head). The right way to do this is just running git submodule update --init -- recursive once upon checkout.

As far as embedding code in a Swift library, we're not embedding modules in the code that we're shipping. Rather, we use git submodules to pull in dependencies (in the form of this repository, and in the form of a protocol buffer repository). I could generate and check in this code if there was some reason that submodules didn't work. You may be right that it's worthwhile checking in static resources by default, and we can certainly investigate doing this in the future.

---

Edit: If you're curious how this is all set up (and why), I wrote a brief primer blog post this week about it: https://blog.xpring.io/xpring-sdk-a-10-00-foot-view/.

[dangell7]

The contributing files definitely helped. I went from error to cloning repos to reading your code. I should have checked there first. They are very clear!

(Aside, if you'd expect to see the build instructions for a repo somewhere other than CONTRIBUTING.md, and I can see if we can make this more obvious).

Place those in the README.md, so hopefully it catches the eye maybe? Idk I'm in here now so I can help direct the questions.