GithubHelp home page GithubHelp logo

Unnecessary keepalive frames about smux HOT 4 OPEN

xtaci avatar xtaci commented on August 18, 2024
Unnecessary keepalive frames

from smux.

Comments (4)

xtaci avatar xtaci commented on August 18, 2024

can you elaborate?

from smux.

sintanial avatar sintanial commented on August 18, 2024

Currently this code https://github.com/xtaci/smux/blob/master/session.go#L383 send keepalive frame (cmdNOP) every 10 seconds.
During intensive data transfer (cmdPSH), keepalive frames(cmdNOP) are not needed. Because the fact of reading data (cmdPSH) already means that the connection is live.

So, I suggest start sending keepalive frames (cmdNOP) after the last successful reading of data.

The simplest solution is replace https://github.com/xtaci/smux/blob/master/session.go#L384 time.Ticker to time.Timer, and after successful reading cdmPSH reset time.Timer (https://golang.org/pkg/time/#Timer.Reset) ;)

from smux.

xtaci avatar xtaci commented on August 18, 2024

for receiving only connection, it's necessary to send cmdNOP perodically. only 8 bytes in 10 seconds.

from smux.

sintanial avatar sintanial commented on August 18, 2024

Maybe you are right and this is overkill :)

from smux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.