Comments (2)
Yes, we have generally made the following answer to CRAN, and every time, they accepted the package an dismissed the note:
The submission to CRAN seems to be rejected automatically over the following NOTE:
* checking pragmas in C/C++ headers and code ... NOTE File which contains pragma(s) suppressing diagnostics:
‘inst/include/xtensor/xstorage.hpp’
The xstorage.hpp file in xtensor adds a pragma and removes it in the end of the file, to prevent an incorrect warning to be triggered by GCC8:
// The C++ standard defines tuple_size as a class, however
// G++ 8 C++ library does define it as a struct hence we get
// clang warnings here
#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wmismatched-tags"
#endif
{
[...]
}
#if defined(__clang__)
#pragma clang diagnostic pop
#endif
In our opinion, this is the correct way to deal with this compiler bug and we actually pop the diagnostic pragma that we pushed after the code triggering it. Hence I don't think that this NOTE should be a blocker for the latest release of xtensor to be accepted on CRAN.
from xtensor.r.
Sounds good! Just wanted to make sure
from xtensor.r.
Related Issues (4)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xtensor.r.