GithubHelp home page GithubHelp logo

Comments (6)

westonruter avatar westonruter commented on May 30, 2024

Oh yeah, that is really nice. When a setting is changed, Settings Revisions should add support for Stream, to be able to attach a link or something to the Stream entry so that they can navigate to the settings_revision post, which should eventually have a nice UI for viewing changes as opposed to the current raw view.

How would this work? Attaching post meta to the Stream post? Upon saving a new settings_revision, would Settings Revision then need to go look up the most recently inserted Stream post for updating settings and then attach the link to it?

from stream.

fjarrett avatar fjarrett commented on May 30, 2024

I think rather than having to look up the most recent record Setting Revisions could maybe just hook into Stream as it saves the record, get the record ID and save a revision ID as record meta. Stream could then just be looking to see if that meta exists, and if it does, provides the revision URL.

from stream.

shadyvb avatar shadyvb commented on May 30, 2024

@westonruter This is the action that SR should hook in: https://github.com/x-team/wp-stream/blob/224f71644020cc30e5db2356e3fe31f8b14dd5c3/includes/db-actions.php?source=cc#L95

from stream.

fjarrett avatar fjarrett commented on May 30, 2024

@shadyvb Can you update which line should be hooked into? Please use a blob URL instead of the master branch so that the link won't go out-of-date.

from stream.

shadyvb avatar shadyvb commented on May 30, 2024

@fjarrett @westonruter Just updated the URL.

from stream.

fjarrett avatar fjarrett commented on May 30, 2024

Relates to #71, which was determined should exist as it's own extension.

from stream.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.