Comments (12)
@TerminusBot I've added a new flag (-t/--timeout
) and bumped the timeout to be 30 seconds by default in #114. I believe that should resolve this problem once and for all. Please let me know if 30 seconds is enough.
from monolith.
I just set the timeout 60 and it works very well now.
from monolith.
@TerminusBot I bumped it to 120 seconds, that seems to be what Chrome and FF are doing regarding network request timeout. If you do -t 0
it'll be infinite. Please let me know if there's anything else that I could improve!
from monolith.
Thank you for the heads up, I'll try to increase the default timeout as well as handle this panic better.
from monolith.
Merged #15 in, should be better on slow connections now, but I think the only way to completely resolve this issue would be to handle failing download attempts in a safe manner (e.g. continue retrieving other assets if one fails).
from monolith.
Thanks, it handling some but still timing out of others
from monolith.
I improved the code to treat all network errors as blank responses, this should help saving pages with resources that timeout or throw other kinds of errors. Please let me know if it got rid of the panic. I'm thinking of adding a -t
option for setting extended timeout in case of slow Internet connection.
from monolith.
thread 'main' panicked at 'called Result::unwrap()
on an Err
value: reqwest::Error { kind: Decode, source: TimedOut }', src/libcore/result.rs:1165:5
note: run with RUST_BACKTRACE=1
environment variable to display a backtrace.
maybe the best solution is retrying if panic happens
from monolith.
@TerminusBot it happens for the very first request, right?
from monolith.
@snshn totally right
from monolith.
I'll look into it this weekend, thank you for the info
from monolith.
@TerminusBot I've added a new flag (
-t/--timeout
) and bumped the timeout to be 30 seconds by default in #114. I believe that should resolve this problem once and for all. Please let me know if 30 seconds is enough.
Sorry, 60 is good enough for me and it works well in production, so I may not test.But you have added the new parameter and we have an easy way to solve this bug.
You have a great job! Monolith helps me a lot. Thanks again!
from monolith.
Related Issues (20)
- whole progress failed caused by get favicon.ico HOT 1
- Unicode mangling
- [Feature request] Simple way to permanently store and use Blacklist of domains HOT 13
- [Bug] Data URLs exceed length limits HOT 8
- Incomplete output on broken HTML like https://distrowatch.com/table.php?distribution=void HOT 5
- Save apple-touch-icon too HOT 3
- "https://mp.weixin.qq.com" web title and CSS switch image on click not work
- How to get just HTML, no <script> HOT 1
- Additionally fetch dynamic content HOT 3
- [proposal] An option to remove alternative sources for media urls HOT 1
- HTML page content partially invisible HOT 2
- Site doesnt work HOT 1
- download path ? HOT 1
- Site doesn't work, redirected towards ct.captcha-delivery.com HOT 1
- What's the default location sites are being saved to? HOT 3
- Relax glibc version requirement HOT 3
- Aggregate multiple html files? HOT 3
- Saving all files separately like IDM. HOT 3
- Minimize output
- Saving Facebook webpages results in a broken output HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from monolith.