Any `CustomErrorException`s thrown within custom code are automatically converted to `WebApplicationException` which discards all error objects about elide

[aklish]

We could probably find a way to expose that so you can customize the errors. We currently have a bean GraphQLConfiguration - but it is not that useful for something like this.

[aklish]

Released yesterday in 7.0.0-pr3

…

On Fri, Apr 21, 2023 at 2:13 PM Lewis Munene ***@***.***> wrote: When will fix this get to Elide version 7? I'm still using version 7.0.0-pr2 (due to Spring Boot 3 support) — Reply to this email directly, view it on GitHub <#2912 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVH6QPIYASK65X2X2AK5L3XCLL6PANCNFSM6AAAAAAVLXVIVA> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[lewimuchiri]

Just followed up and seen that the code that's causing this to happen is this one:

It's inside com.yahoo.elide.graphql.QueryRunner. It's throwing a new exception of type WebApplicationException which is causing it to lose all error objects in the original CustomErrorException.

[aklish]

I see the first issue with Jersey, but not the second when I throw a CustomErrorException from a lifecycle hook. My custom error hits the error mapper and it includes all the error objects. Are you sure your lifecycle hook is triggering the exception (and not some other error)?

HTTP/1.1 200 OK
Date: Sun, 05 Mar 2023 01:27:18 GMT
Vary: Origin
Vary: Access-Control-Request-Method
Vary: Access-Control-Request-Headers
X-Content-Type-Options: nosniff
X-XSS-Protection: 0
Cache-Control: no-cache, no-store, max-age=0, must-revalidate
Pragma: no-cache
Expires: 0
X-Frame-Options: SAMEORIGIN
Content-Type: application/json
Content-Length: 47

{
    "errors": [
        {
            "message": "Custom Error Message"
        }
    ]
}

[aklish]

Ok - I see the second issue now too for PREFLUSH and PRESECURITY hooks.

[aklish]

So it looks like graphql-java swallows the exception:

The exception is there, but there is no method on GraphQLError to get at it. In short, we can fix the first problem (the jersey issue), but I don't know of a solution to fix the 2nd without a corresponding patch to graphql-java.

[lewimuchiri]

Yes, correct. I'm throwing my exception in a PRESECURITY hook.
For the 'ErrorObjects getting lost' problem, I suppose we can resolve this by defining a custom exception that implements GraphQLError. We can then add our extra errors to the extensions field (which is a map) in the Graphql error

[lewimuchiri]

Again, using Elide, there's no way of overriding Graphql's DataFetcherExceptionHandler so that you can throw your own custom exceptions as you'd like. This is because we have to do something like this:

@Bean
public GraphQL graphQL(GraphQLSchema schema) {
    return GraphQL.newGraphQL(schema)
            .queryExecutionStrategy(new AsyncExecutionStrategy(new CustomDataFetcherExceptionHandler()))
            .mutationExecutionStrategy(new AsyncSerialExecutionStrategy(new CustomDataFetcherExceptionHandler()))
            .build();
}

which gives the error No beans of GraphQLSchema type found

[lewimuchiri]

When will fix this get to Elide version 7? I'm still using version 7.0.0-pr2 (due to Spring Boot 3/Java 17 support). Version 7.0.0-pr2 is the only one that's available on Maven Central

[lewimuchiri]

Thanks. Good stuff