Promotion crash about unciv

[hackedpassword]

Yep that's what it is: pulling promotions out mid-game is confusing Unciv. I went back and copied each changed Example I to another Example promotion. Having the legacy promo allowed next turn to complete.

[SomeTroglodyte]

So it's not our bug except if we want to prevent such happenings actively - by updating GameInfo.removeMissingModReferences (in BackwardCompatibility) so these bad references are caught? removeUnitsAndPromotions sounds like it should already... Only runs on game load though. Is there a loophole to reload mods and rebuild a ruleset without... nah, impossible.

With exact steps to repro we could debug maybe.

[yairm210]

When you change promotions, units with existing promotions that no longer exist have them removed.
The problem here is that we didn't safeguard against uniques granting this promotion - probably "All newly-trained [baseUnitFilter] units [cityFilter] receive the [promotion] promotion" but I would check the mod checker on your end.