Spell check as you type about yakyak

[royts]

+1

[davibe]

reopened cuz the first solution we attempted did not work properly across different operating systems

[ruzz311]

bump

[Sonny-Crockett]

Any word on this getting added? Great app too. Love it, this is the only issue for me at this time.

+1

[rjcrouch]

I'm more of a designer than a developer but would it be possible to leverage this open source js spell checker?

http://www.javascriptspellcheck.com/Software_License_for_JavaScript_SpellCheck

[aersoares81]

I don't know why it doesn't let OS X handle spell check like it does elsewhere.

[algesten]

electron/electron#942

[cakebot]

+1

[TwisterMc]

+1

[tryton-vanmeer]

+1

[zaphod777]

+1 I love this app but the lack of spell checking is a real pain.

[lihaven]

+1

[andreykats]

+1

[georgemastro]

+1

[jkuss]

If this issue will be the duplicate of my request #237 , let me say that I would like OS X autocorrect enabled as well as spell check highlighting.

[pdm-pcb]

+1

[bmneely]

+1 to this. Please please please do this.

[averissimo]

This could be done via using webframe.setSpellProvider

https://github.com/electron/electron/blob/master/docs/api/web-frame.md#webframesetspellcheckproviderlanguage-autocorrectword-provider

tested it with a toy example, which basically showed every word as misspelled.

const {webFrame} = require('electron')
webFrame.setSpellCheckProvider('en-US', true, {
  spellCheck (text) {
    return false;
  }
})

Also tried using node-spellchecker but I was getting errors when loading the module.

Uncaught Error: Module version mismatch. Expected 50, got 48.

Tried rebuilding npm with right --abi=50 but still failed

If someone wants to pick this up it's really easy if they get pass this.

I believe these are the steps required if someone wants to pick this up

• have it working with node-spellchecker
• add to context menu suggested words (this has to be done dynamically, see this issue
• add an option to define the language to be used (until now all that's implemented are true/false configurable options)

edit: @monchote already tried the first option and there's already an example in his pull request ... didn't notice it :)

[monchote]

@averissimo My branch worked just fine in macOS and Linux. I never managed to make it compile from Windows. The main downside of using node-spellchecker is that it requires compiling individually for each platform.

[AlaaAlShammaa]

+1 to this. Please please please do this.

[cdeneen]

+1

[TwisterMc]

This was shared with me. Maybe it helps?

https://github.com/electron-userland/electron-spellchecker
electron-spellchecker is a library to help you implement spellchecking in your Electron applications, as well as handle default right-click Context Menus (since spell checking shows up in them). This library intends to solve the problem of spellchecking in a production-ready, international-friendly way.

[averissimo]

Will this require to compile libraries under specific operating systems? I believe @monchote had a solution

The problem is that the dictionary libraries needed to be compiled separately in windows / linux / osx (@monchote, correct me if i'm mistaken)

[monchote]

@averissimo That was the main issue, indeed.

[ruzz311]

I have only been using yakyak for a little bit on mac and I used to think I could live without some spell-checking (either via node or leveraging the system).

Wouldn't support for some be better than none? If it's a problem for some systems they deserve more planning rather than weigh down obtainable solutions. Are there docker containers we could make that we could leverage for builds so native compiling would be less of a problem for the project?

That being said, I've not looked at the code yet but I do really love a lot about this app. I'll try to back read what's already been attempted by @monchote and @averissimo above but I haven't spent a lot of time with the electron api so any suggestions about stumbling blocks for this issue would be appreciated 👍

[tiagonunocosta]

+1
If it is necessary I am willing to pay for a version with automatic correction

[bmneely]

This would also be a feature I'd be very happy to pay for.

[TwisterMc]

There is another thread on spelling that offers up a solution to devs: #683

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[zaphod777]

Still hoping to have spellcheck on Mac before the new Allo web client comes out :-/

[averissimo]

Unfortunately it seems like the person that suggested was wrong (his words)

Last I visited this issue it still required Yakyak to be compiled in different environments, Linux, OSX and Windows. Has something changed related to this?

As we build using Travis-CI.org we would be able to do it in Linux and OSX (if the experiment I'm doing today works)

Question for anyone that knows (hint hint @monchote ) can we compile the necessary libraries for windows using wine?

[tiagonunocosta]

Thank you André

I already use yakyak for a few months, but what I need most is not to allow automatic correction of spelling mistakes.

I've been following the forum, but can not figure out how to enable this feature.

I'm using MAc

[averissimo]

the feature has not been implemented yet, as it requires an infrastructure that supports all 3 main systems OSX, Windows and Linux.

Currently we are building only in Linux for all binaries. (just yesterday we successfully built on both linux and mac osx, thus my question on the comment before :)

That could allows us to actually use spellchecker, but it's still an if, as we would need someone to write/adapt @monchote code and send a pull request

[monchote]

When I worked on this I managed to compile and make it work on both Mac and Linux. I set up a Windows 10 VM and spent many ours trying to build it there with no success.

I'm not sure what the current state is as I haven't looked into it for a while.

Maybe it's worth adding the code and having it work on Mac and Linux even if it doesn't do much on Windows until a solution is found?

[averissimo]

What is the process to build the code with spell check support in the #271 pull request?

I.e. any external commands, or this is already done when building the spellchecker module?

[monchote]

Nothing special as far as I remember.

[averissimo]

ok, so what was failing in windows? compiling the code or installing the modules?

[monchote]

Setting up the environment and building the project. It was a bit of a nightmare.

[averissimo]

LoL you make it sound soooo awesome!! :p

We either need to do it via wine or using a windows CI (continuous integration) service

Otherwise it won't be an automated process which sucks

Thanks for the continuous feedback, I'm sure that sooner or later your code will be merged!!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[nickkeyzer]

+1 - I use this app every day on Linux. Would love to have the spellcheck functionality.

[nokaoii]

+1

[andreykats]

+1

[KevDoy]

+1

[jonathanhagler]

+1

[lmgutman]

+1

[PrestonMonteWest]

+1

[exoticDFT]

+1

[asenchristov]

+1

[plinkowski]

Please add spell check for Mac OSX

[zaphod777]

Please add spell check for Mac OSX

I'm just going to go out on a limb and say it isn't going to happen.

[adampatterson]

Please Please Please 😀

[craigthings]

I'll throw on another vote. Switched to Firefox and I need a dedicated desktop app. This works fantastically but I need me some spellcheck!

Why not just throw in something like electron-spellchecker ?

+1!

[Jeager2]

Spellcheck and auto-correct has been requested since 2015? Really?
+1 !
+1000 !

[jessejoe]

Looks like with the upgrade to Electron v9 in YakYak 1.5.8, spellcheck is enabled now! At least I'm seeing it on macOS:

[zaphod777]

It only took 4 years, lol. Thanks, Nicholas Vilppu

…

On Wed, Jun 17, 2020 at 5:46 AM Jesse Jarzynka ***@***.***> wrote: Looks like with the upgrade to Electron v9 in YakYak 1.5.8, spellcheck is enabled now! At least I'm seeing it on macOS: [image: image] <https://user-images.githubusercontent.com/1694586/84826300-c1673600-aff0-11ea-83c4-e55d904c6a6e.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#61 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOVY6MXT3ZBURGF33RPGNLRW7K2LANCNFSM4BQRGKPA> .

[adampatterson]

Amazing!

[adampatterson]

I may have jumped to conclusions, I can see typos, but there isn't a suggested spelling available.

But at least I can see a mistake quicker.

[averissimo]

Good news for this issue as I just merged an implementation of spell check that electron has (what @jessejoe and @adampatterson mentioned) #1201

This is now "implemented" on v1.5.10-beta-rolling

I've tested on Ubuntu (linux) all the bullet points below, but I'd like to ask users to test if it works as expected in Windows, MacOSX and Linux

Checklist on what should work:

• It's off by default... red underline no longer appears
• Context menu has options to turn it on
• It actually corrects misspellings
• Turns on and off
• Language switching works

ps. I couldn't find a way to map locale to language string (pt-PT -> Portuguese) so unless someone creates a pull request, that's how it's staying.

[averissimo]

I'd really appreciate if someone could check if this works in platforms other than Linux :)

[asenchristov]

Hi,
on Kubuntu 20.04 LTS, v1.5.10: works, mostly:
if you go to the menu, then help --> about and then return to conversation, then right clicking will not work properly, it will attempt do display menu for spellchecking but fails and displays only "Copy".

[averissimo]

Wow @asenchristov !! thanks for discovering that.

Corrected and already available in v1.5.10-beta-rolling

[jessejoe]

@averissimo v1.5.10-beta-rolling is stuck at "Connecting" on macOS, so I'm unable to test. 1.5.9 connects fine, I wonder if it's missing one of the fixes.

[averissimo]

I inadvertently made a beta build that was buggy as hell and reverted in a few minutes.

I've just tested with the deb and linux tar file and they both work.

@jessejoe Can you check now?

[jessejoe]

@averissimo seems to work! Although I'm not sure the context menu is the best place to put the toggle for on/off, I never would've looked there for it.

[averissimo]

Do you have any suggestions?

I placed it there as it's likely to be accidentally discovered

[jessejoe]

I think if it was enabled by default, it's an OK place. Otherwise an option in one of the app menus.

[serk12]

Hi,
on Kubuntu 20.04 LTS, v1.5.10: works, mostly:
if you go to the menu, then help --> about and then return to conversation, then right clicking will not work properly, it will attempt do display menu for spellchecking but fails and displays only "Copy".

I have the same problem in ubuntu 20.04 and also I can't find the spell checker option.