yanniz0r / sonq Goto Github PK

• Preview picture
• How to get the development started
• How to deploy this thing
• Contribution

In order to prevent high load, spam and unfair play, we need to implement a cooldown between answers

We need to show an error message when no game can be found with the given game id

In order to give the user an impression of what they have to expect, a detailed game description should be on the landing page. It should allow the user to understand how the game works, what interactions are required and what the rules are

Die Kurzeinladung sollte erstellt werden.

UUID auf Kurz umstellen

siehe Bild

After finishing a round early, the song continues to play. If this is desired, a user should be able to control the volume

The lobby page should have share button for...

• WhatsApp
• Telegram
• E-Mail
• Slack?

In Safari music autoplay is prevented due to a policy.
Maybe user agreement could help.

Volume Control Slider Icon should change depending on volume value

When a player name is too long the according avatar gets squeezed and looks bad.

If the playlists image is not a square, we end up with some really funky layouts. Pls fix.

• Debounce Requests to spotify song search as high demand might result in exceeded rate limits
• Show different states for pre game delay and actual listening time
• Add immediate feedback for guess
• (Optional) Add explanation for song search

The two statistics are shown for the same player. This is not correct.

Long song titles may break the grid layout. Thats pretty bad. Please fix

After the game, a summary of the recent game should be shown. Its contents are to be defined. However, it should include the following things:

• The final player scores of the game, sorted from first to last place
• Some kind of button that allows the admin to start a new round. It probably makes sense to exclude previously guessed songs.
• Before the round starts, the games admin should be allowed to adjust the games settings easily

The following things should be considered for implementation but are not necessary:

• A list of songs that were guessed in the previous round. Additionally, it could feature an overview of the players scores for each song

Add english translations and implement language detection

At some points, the toolbars content and the pages content are not aligned properly. You can see it in the screenshot below.

The statistics translations on the summary page are currently missing for the german version

"Built with heart by yanniz0r" mit "Written with ❤️ by yanniz0r" ersetzen!!!!!!!!!!!!!!!!!!!!!!!!!

Currently, the user gets redirected to the sonq.vercel.app domain. This is not correct, it should be sonq.de

It might happen that there is no data for a given statistic. We should show at least the title of the statistic then.

Because we use a similar pane layout for the review and summary page, I built some generic pane components. The should be reused on the review page as they are only used on the summary page so far. There might be some adjustments that have to be made though.

Currently, going to the options page results in two socket connections. The old one should preferably be reused, if not possible removed.

Wir könnten an sonq weiterbauen..
Feature idee

• auto cert renew

• empfohlene playlists mit Songs welche auch bekannt sind

• regeln hinzufügen wenn eine playlist mehr als 50 songs hat das bei der Suche nur songs kommen welche in der playlist sind um Remixe oder Covers falsch Picks zu vermeiden.

• Jeder Teilnehmer kann ne Playlist vorschlagen und der Zufall entsccheidend

• kleines loginsystem um Rangliste zu führen (gastlogin ist auch ne Möglichkeit ohne das highscores) gespeichert sind...
  (halt bei ausgewählten playlists)

As a player I want to be able to see the current points of all players so I know how good they are

• Übersetzungsfehler auf der Hauptseite:

• Spotify Redirect Error - Wenn man auf "Abbrechen" drückt kommt man auch auf die "Erstelle Spiel Seite" was ja aber nicht funktioniert :)
  

The player should have the possibility to control the songs volume with a slider

After going to the edit screen, previous settings are not present anymore. As a user I would expect to see my previous settings again which I can alter then.

Empty games should be removed from the memory. However, a game is currently created before a player joined. Therefore, we can't simply check if the list is empty. Rough sketch:

1. We remove the game after the last player left
2. We periodically run through all games, check if they have players and if not remove them. Maybe every 10 minutes? We have to check how old the game is, otherwise we might remove a newly created game

After finishing a round, starting a new one does not work.

• Show wrong song guesses
• Add link to current song (with target "_blank")

• Die Entertaste bei der Playlist suche startet das Spiel (Man kommt zur "Spielernamen" eingabe). Es wurde aktiv aber keine Playlist ausgewählt, bzw man weiß nicht ob eine Playlist ausgewählt wurde

• Spielt man allein, und das Ergebnis wurde richtig getippt, kommt man ja zum "Ergebnisscreen" Dort läuft die Musik weiter bis der Preview fertig ist. Ein automatisches Stoppen wenn alle das richtige Ergebnis haben wäre super.

• Der Countdown wo zeigt wie lange man noch Zeit zum raten hat stoppt bereits bei ca. 4 Sekunden und schickt einen ins Ergebnissmenü wenn keiner es errät (Spiele aktuell allein)

On the review page, two next round buttons are shown. This is not good. Please remove the one that is not within the wonderful pink sidebar! :)

Mitspieler haben einen nicht funktionierenden Startbutton

• The player overview should be focused, maybe with a fancy state transition
• The link to the current game should be visible
• (Optional) a share button? Maybe Whatsapp?

The top right statistic on the summary page does not show any data although it should

As a user I want to be able to play the game in a non remote environment so that I can play without being stuck in a zoom call

Some songs have unsupported encodings. We either have to filter them out or allow the browser to play it.

Currently users have no way to submit feedback. A link to this repo should be sufficient.

All files with hardcoded text should be changed so they use the translation hook

The application should be deployed to a staging and a production environment. For the deployment, the following infrastructure should be used:

1. Vercel: Frontend Server
2. Dokku/SRV1: Backend Server

In order to make the application accessible, a new domain has to be configured for each application.

As some parts of the application are hardecoded (eg. the backend url in the client), adjustments have to be made to the application.

Currently, everyone is able to change the settings. Only someone with a valid admin key should be allowed to do so.

The whole socket connection stuff got a little bit bloated. Therefore we should refactor it to achieve the following:

• Components mostly consume data from a store rather than collecting them themselves
• The whole socket connection is typesafe
• Logic should not be in the components anymore

I think it would be good to have a guide for naming conventions for translation reference names.
Maybe as readme in the locale folder.