Close when user clicks off modal (on overlay) about ember-modal-dialog

[lukemelia]

Yes, it's easy to do today. See the examples in the dummy app to learn how.

[oskarrough]

Where exactly is it in the dummy app? I couldn't find it. Thank you!

[theworkerant]

@oskarrough You're right this was hard to find:

ember-modal-dialog/addon/templates/components/modal-dialog.hbs

Line 3 in abb32b0

<div {{bind-attr class="overlayClassNamesString translucentOverlay:translucent overlay-class"}} {{action 'close'}}></div>

If you want to override this sucker, look here:

ember-modal-dialog/addon/components/modal-dialog.js

Line 48 in abb32b0

actions: {

And do something similar as suggested in the README for Keyboard Shortcuts

[lukemelia]

@theworkerant / @oskarrough sorry this was tough to understand. Can one of you submit a PR that would make it easier to grok for a developer new to the project?

[pzuraq]

@lukemelia I think the issue is that the documentation doesn't clearly specify how the close action is triggered, I made a PR to fix that. If the close action is sent from other places besides clicking the overlay let me know, I can clarify further.

[oskarrough]

Thank you @pzurag, helped me!