GithubHelp home page GithubHelp logo

Comments (5)

strangedev avatar strangedev commented on June 2, 2024

For clarity: 5fb96dd disallows the problematic adding of shadows, and leaves the delete logic unchanged.

from st3k101.

yeldiRium avatar yeldiRium commented on June 2, 2024

Since now the invalid state is not reachable anymore, this can be closed, right?

from st3k101.

strangedev avatar strangedev commented on June 2, 2024

No, since the branch was not merged yet.

from st3k101.

strangedev avatar strangedev commented on June 2, 2024

Follow up: We can't just disallow this in the API, the front end should also detect this case and disallow it, otherwise this will be confusing to users.

from st3k101.

strangedev avatar strangedev commented on June 2, 2024

Adding a Shadow* to a parent which includes the referenced Concrete* breaks delete #76

from st3k101.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.