GithubHelp home page GithubHelp logo

Comments (14)

arthurvr avatar arthurvr commented on July 17, 2024

Fixed. Thanks.

from generator-node.

nfriedly avatar nfriedly commented on July 17, 2024

Whoot, nice turnaround time!

from generator-node.

SBoudrias avatar SBoudrias commented on July 17, 2024

Released as 1.2.1

from generator-node.

nfriedly avatar nfriedly commented on July 17, 2024

Awesome!

On a vaguely related note, do you guys have any thoughts on adding an option to output ES5 javascript for publishing on npm and such? I know it isn't too difficult to set up, but I was a bit surprised when I realized that it wasn't built-in to the default generator-node setup. (Or is there a flag to turn it on that I just missed?)

from generator-node.

arthurvr avatar arthurvr commented on July 17, 2024

@nfriedly It's optional. Just use --no-babel if you don't want babel.

from generator-node.

nfriedly avatar nfriedly commented on July 17, 2024

Yea, that's what I ended up doing, but I was asking about an option that lets me write es6/7 but automatically generates es5 (in out/ maybe) and sets that up to be published to npm? So, more of a --with-debabeling sort of option.

from generator-node.

SBoudrias avatar SBoudrias commented on July 17, 2024

@arthurvr is Babel activated by default? I think we should do simple es5 by default as es6-7 is a harder publishing process.

from generator-node.

arthurvr avatar arthurvr commented on July 17, 2024

@SBoudrias Yes. I like that, personally. That's what we plan for other generators too.

from generator-node.

SBoudrias avatar SBoudrias commented on July 17, 2024

@arthurvr could you look what the current case is for generator-node and send a PR fixing it if it's an issue?

from generator-node.

arthurvr avatar arthurvr commented on July 17, 2024

@SBoudrias What do mean with "the current case"? The publishing process? Or the fact that Babel is on by default?

from generator-node.

SBoudrias avatar SBoudrias commented on July 17, 2024

@arthurvr Let me rephrase: can you send a PR making babel an option who's not the default?

from generator-node.

arthurvr avatar arthurvr commented on July 17, 2024

Yes I can, though, why? That's not the approach we're taking with other generators. It's future-proof, doesn't complicate the build more than a simple gulp task and I think it's a good idea to promote using ES6.

from generator-node.

robbbz avatar robbbz commented on July 17, 2024

Why would anybody possible mind more features, in a backwards compatible way? As said in the other generator by silvenon as well, I don't think it should even be optional.

from generator-node.

SBoudrias avatar SBoudrias commented on July 17, 2024

Well, speaking for myself here, I still develop in ES5 and I don't intend to start using babel by default anytime soon.

Maybe it's only my opinion, but the overhead of setting up babel is usually not worth the syntactic sugar it provide me.

ES5 is working fine, I don't see why we should be eager to integrate more tooling.

from generator-node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.