Why care about env{test}_out splits about adanpc

[yfzhang114]

This is used in our ablations and testing and doesn't affect the sweep process.

[yfzhang114]

As you said, in is used for testing, so we store out for the model selection. The ent is not necessary so here we just set it to ACC and do not log the ent value. If you need to print the value of ents (mostly for the DRM baseline), you can set ent_on_test.append(ent), Maybe I do not understand the problem clearly, so if there is any problem exists, just submitting another question.

[mynameisissac]

Ok thanks, so it means how you selected the best hyperparams combination for Ada is actually by results_on_test (or the best acc on test printed on line 442) ?

AdaNPC/unsupervised_adaptation.py

Lines 442 to 443 in 007ec44

	print("best acc on test {:.1f}".format(results_on_test[idx]*100))
	print("best acc with ent {:.1f}".format(ent_on_test[idx]))