Double formatting of the response body about data-response

[Gerych1984]

Good afternoon. I wanted to write a PR for this issue, but on tests I didn't understand the logic of working with headers. Some headers are forced from the formatter, but others can be deleted/changed from DataResponse. For example:

DataResponseTest::testWithoutHeader we deleted Content-Type from formatter, but in DataResponseTest::testFormatterCouldChange*** we forced it from formatter ignoring DataResponse called methods.

Wouldn't it be better and more logical if DataResponse behaves completely like ResponseInterface? If a user calls DataResponse::withProtocolVersion('1.0') etc then he should get 1.0.

And that's how we get:

$formatter = (new CustomDataResponseFormatter())->withProtocol('2.0');
$dataResponse = $this
    ->createDataResponse(['test'])
    ->withResponseFormatter($formatter);

echo $dataResponse->getProtocolVersion(); //'2.0'

But call $dataResponse->withProtocolVersion('*') equals $formatter->withProtocol('*') in this case

$formatter = (new CustomDataResponseFormatter())->withProtocol('2.0');
$dataResponse = $this
    ->createDataResponse(['test'])
    ->withResponseFormatter($formatter)
    ->withProtocolVersion('1.0');

echo $dataResponse->getProtocolVersion(); //'1.0'

But if we set $dataResponse->withProtocolVersion('*') before formatter in this case $formatter can force own headers. Like $dataReader->withProtocolVersion($formatter->protocol)

$formatter = (new CustomDataResponseFormatter())->withProtocol('2.0');
$dataResponse = $this
    ->createDataResponse(['test'])
    ->withProtocolVersion('1.0')
    ->withResponseFormatter($formatter);

echo $dataResponse->getProtocolVersion(); //'2.0'

[samdark]

@devanych do you remember why it is like that?